Fix missing and incorrect AccessibilityInfo types (#56708)#56708
Closed
huntie wants to merge 1 commit intofacebook:mainfrom
Closed
Fix missing and incorrect AccessibilityInfo types (#56708)#56708huntie wants to merge 1 commit intofacebook:mainfrom
huntie wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104057500. |
huntie
changed the title
meta-codesync
Bot
changed the title
huntie
added a commit
to huntie/react-native
that referenced
this pull request
May 7, 2026
Summary: Pull Request resolved: facebook#56708 **Context** Claude-driven audit of Flow source code vs existing public TypeScript API (manual). **Changes** Alignments to the `AccessibilityInfo` module for both the source Flow types and manual TS types: - **Flow**: Move `grayscaleChanged` and `invertColorsChanged` into shared `AccessibilityEventDefinitions` — both events are registered on both platforms in the `EventNames` map. - **TS**: Add missing event types (`accessibilityServiceChanged`, `announcementFinished`, `darkerSystemColorsChanged`, `highTextContrastChanged`, `windowStateChange`) and platform-specific JSDoc to `AccessibilityChangeEventName` members. Changelog: [General][Fixed] - Fix missing and incorrect types in `AccessibilityInfo` TypeScript definitions Reviewed By: christophpurrer Differential Revision: D104057500
huntie
added a commit
to huntie/react-native
that referenced
this pull request
May 7, 2026
Summary: Pull Request resolved: facebook#56708 **Context** Claude-driven audit of Flow source code vs existing public TypeScript API (manual). **Changes** Alignments to the `AccessibilityInfo` module for both the source Flow types and manual TS types: - **Flow**: Move `grayscaleChanged` and `invertColorsChanged` into shared `AccessibilityEventDefinitions` — both events are registered on both platforms in the `EventNames` map. - **TS**: Add missing event types (`accessibilityServiceChanged`, `announcementFinished`, `darkerSystemColorsChanged`, `highTextContrastChanged`, `windowStateChange`) and platform-specific JSDoc to `AccessibilityChangeEventName` members. Changelog: [General][Fixed] - Fix missing and incorrect types in `AccessibilityInfo` TypeScript definitions Reviewed By: christophpurrer Differential Revision: D104057500
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
Summary: Pull Request resolved: facebook#56708 **Context** Claude-driven audit of Flow source code vs existing public TypeScript API (manual). **Changes** Alignments to the `AccessibilityInfo` module for both the source Flow types and manual TS types: - **Flow**: Move `grayscaleChanged` and `invertColorsChanged` into shared `AccessibilityEventDefinitions` — both events are registered on both platforms in the `EventNames` map. - **TS**: Add missing event types (`accessibilityServiceChanged`, `announcementFinished`, `darkerSystemColorsChanged`, `highTextContrastChanged`, `windowStateChange`) and platform-specific JSDoc to `AccessibilityChangeEventName` members. Changelog: [General][Fixed] - Fix missing and incorrect types in `AccessibilityInfo` TypeScript definitions Reviewed By: christophpurrer Differential Revision: D104057500
|
This pull request has been merged in 4255f9b. |
Collaborator
|
This pull request was successfully merged by @huntie in 4255f9b When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Claude-driven audit of Flow source code vs existing public TypeScript API (manual).
Changes
Alignments to the
AccessibilityInfomodule for both the source Flow types and manual TS types:grayscaleChangedandinvertColorsChangedinto sharedAccessibilityEventDefinitions— both events are registered on both platforms in theEventNamesmap.accessibilityServiceChanged,announcementFinished,darkerSystemColorsChanged,highTextContrastChanged,windowStateChange) and platform-specific JSDoc toAccessibilityChangeEventNamemembers.Changelog:
[General][Fixed] - Fix missing and incorrect types in
AccessibilityInfoTypeScript definitionsReviewed By: christophpurrer
Differential Revision: D104057500