Remove V0 nightly download path from hermes-utils.rb (#56755)#56755
Closed
cipolleschi wants to merge 8 commits into
Closed
Remove V0 nightly download path from hermes-utils.rb (#56755)#56755cipolleschi wants to merge 8 commits into
cipolleschi wants to merge 8 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104649630. |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 11, 2026
Summary: Pull Request resolved: facebook#56755 Remove the legacy Hermes V0 nightly (Maven Snapshots) download path: - Remove DOWNLOAD_PREBUILT_NIGHTLY_TARBALL source type constant - Remove nightly_artifact_exists(), nightly_tarball_url(), podspec_source_download_prebuilt_nightly_tarball() - Remove net/http and rexml/document requires (only needed for nightly XML parsing) - Rename BUILD_FROM_GITHUB_MAIN -> BUILD_FROM_GITHUB_STABLE_BRANCH (was always targeting the stable V1 branch) - Rename force_build_from_main -> force_build_from_stable_branch - Rename podspec_source_build_from_github_main -> podspec_source_build_from_github_stable_branch - Extract HERMES_STABLE_BRANCH constant so the hardcoded branch is in one place Differential Revision: D104649630
meta-codesync
Bot
changed the title
cipolleschi
force-pushed
the
export-D104649630
branch
from
7bc891c to
160ad79
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 11, 2026
Summary: Pull Request resolved: facebook#56755 Remove the legacy Hermes V0 nightly (Maven Snapshots) download path: - Remove DOWNLOAD_PREBUILT_NIGHTLY_TARBALL source type constant - Remove nightly_artifact_exists(), nightly_tarball_url(), podspec_source_download_prebuilt_nightly_tarball() - Remove net/http and rexml/document requires (only needed for nightly XML parsing) - Rename BUILD_FROM_GITHUB_MAIN -> BUILD_FROM_GITHUB_STABLE_BRANCH (was always targeting the stable V1 branch) - Rename force_build_from_main -> force_build_from_stable_branch - Rename podspec_source_build_from_github_main -> podspec_source_build_from_github_stable_branch - Extract HERMES_STABLE_BRANCH constant so the hardcoded branch is in one place Differential Revision: D104649630
cipolleschi
force-pushed
the
export-D104649630
branch
from
160ad79 to
0744eb3
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 11, 2026
Summary: Pull Request resolved: facebook#56755 Remove the legacy Hermes V0 nightly (Maven Snapshots) download path: - Remove DOWNLOAD_PREBUILT_NIGHTLY_TARBALL source type constant - Remove nightly_artifact_exists(), nightly_tarball_url(), podspec_source_download_prebuilt_nightly_tarball() - Remove net/http and rexml/document requires (only needed for nightly XML parsing) - Rename BUILD_FROM_GITHUB_MAIN -> BUILD_FROM_GITHUB_STABLE_BRANCH (was always targeting the stable V1 branch) - Rename force_build_from_main -> force_build_from_stable_branch - Rename podspec_source_build_from_github_main -> podspec_source_build_from_github_stable_branch - Extract HERMES_STABLE_BRANCH constant so the hardcoded branch is in one place Differential Revision: D104649630
cipolleschi
force-pushed
the
export-D104649630
branch
from
0744eb3 to
1e9a872
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 11, 2026
Summary: Pull Request resolved: facebook#56755 Remove the legacy Hermes V0 nightly (Maven Snapshots) download path: - Remove DOWNLOAD_PREBUILT_NIGHTLY_TARBALL source type constant - Remove nightly_artifact_exists(), nightly_tarball_url(), podspec_source_download_prebuilt_nightly_tarball() - Remove net/http and rexml/document requires (only needed for nightly XML parsing) - Rename BUILD_FROM_GITHUB_MAIN -> BUILD_FROM_GITHUB_STABLE_BRANCH (was always targeting the stable V1 branch) - Rename force_build_from_main -> force_build_from_stable_branch - Rename podspec_source_build_from_github_main -> podspec_source_build_from_github_stable_branch - Extract HERMES_STABLE_BRANCH constant so the hardcoded branch is in one place Differential Revision: D104649630
cipolleschi
force-pushed
the
export-D104649630
branch
from
1e9a872 to
c684d96
Compare
cortinico
approved these changes
May 11, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 11, 2026
Summary: Pull Request resolved: facebook#56755 Remove the legacy Hermes V0 nightly (Maven Snapshots) download path: - Remove DOWNLOAD_PREBUILT_NIGHTLY_TARBALL source type constant - Remove nightly_artifact_exists(), nightly_tarball_url(), podspec_source_download_prebuilt_nightly_tarball() - Remove net/http and rexml/document requires (only needed for nightly XML parsing) - Rename BUILD_FROM_GITHUB_MAIN -> BUILD_FROM_GITHUB_STABLE_BRANCH (was always targeting the stable V1 branch) - Rename force_build_from_main -> force_build_from_stable_branch - Rename podspec_source_build_from_github_main -> podspec_source_build_from_github_stable_branch - Extract HERMES_STABLE_BRANCH constant so the hardcoded branch is in one place ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D104649630
cipolleschi
force-pushed
the
export-D104649630
branch
from
c684d96 to
3fea1e6
Compare
…oad the correct commit data. Differential Revision: D104228879
…oad the correct commit data. Differential Revision: D104244582
…56735) Summary: Pull Request resolved: facebook#56735 - Remove `RCT_HERMES_V1_ENABLED` environment variable from `react_native_pods.rb` - Simplify `jsengine.rb` to always use `.hermesversion` tag file - Remove conditional `HERMES_V1_ENABLED=1` preprocessor definition from `utils.rb` - Simplify `hermes-engine.podspec`: always read `HERMES_VERSION_NAME`, use V1 source files, remove legacy inspector subspecs - Simplify `hermes-utils.rb`: remove `hermes_v1_enabled()` function, always use `250829098.0.0-stable` branch, always use `.hermesversion` tag file ## Changelog: [iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods ## Test plan - [x] iOS: `bundle exec pod install` — success - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED Differential Revision: D104247277 Reviewed By: cortinico
Differential Revision: D104380961
Differential Revision: D104381269
Summary: Hermes V1 (Static Hermes) is now always enabled. Remove the isHermesV1 variable and inline its effects: - enableRegenerator is always based on dev mode (was isHermesV1 && dev) - preserveClasses is always true (was isHermesV1) Also update the comments to drop the 'V1' framing. Differential Revision: D104649639
Summary:
The legacy Hermes V0 nightly dist-tag ('nightly') has been removed. This commit
cleans up the ios-prebuild Hermes download logic:
- Remove the 'nightly' sentinel string and getNightlyVersionFromNPM()
- Remove DOWNLOAD_PREBUILT_NIGHTLY_TARBALL source type and downloadPrebuiltNightlyTarball()
- Remove getNightlyTarballUrl() (was fetching from Maven Snapshots for V0 nightlies)
- Rename getLatestV1VersionFromNPM -> getLatestHermesVersionFromNPM
- Update prepare-app-utils.js to use 'latest-v1' instead of 'nightly' for HERMES_VERSION
Differential Revision: D104649632
Summary: Pull Request resolved: facebook#56755 Remove the legacy Hermes V0 nightly (Maven Snapshots) download path: - Remove DOWNLOAD_PREBUILT_NIGHTLY_TARBALL source type constant - Remove nightly_artifact_exists(), nightly_tarball_url(), podspec_source_download_prebuilt_nightly_tarball() - Remove net/http and rexml/document requires (only needed for nightly XML parsing) - Rename BUILD_FROM_GITHUB_MAIN -> BUILD_FROM_GITHUB_STABLE_BRANCH (was always targeting the stable V1 branch) - Rename force_build_from_main -> force_build_from_stable_branch - Rename podspec_source_build_from_github_main -> podspec_source_build_from_github_stable_branch - Extract HERMES_STABLE_BRANCH constant so the hardcoded branch is in one place ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D104649630
cipolleschi
force-pushed
the
export-D104649630
branch
from
3fea1e6 to
d79a007
Compare
|
This pull request has been merged in 99988ab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove the legacy Hermes V0 nightly (Maven Snapshots) download path:
Changelog:
[Internal] -
Reviewed By: cortinico
Differential Revision: D104649630