Migrate NativeViewHierarchyManager from Java to Kotlin (#56828)#56828
Closed
cortinico wants to merge 1 commit into
Closed
Migrate NativeViewHierarchyManager from Java to Kotlin (#56828)#56828cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104999732. |
cortinico
force-pushed
the
export-D104999732
branch
from
14f8c12 to
15bbd41
Compare
meta-codesync
Bot
changed the title
cortinico
force-pushed
the
export-D104999732
branch
from
15bbd41 to
b845b54
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 20, 2026
Summary: Pull Request resolved: facebook#56828 Mechanical migration of the deprecated `NativeViewHierarchyManager` stub class from Java to Kotlin. All methods remain empty stubs — no behavioral changes. Key migration decisions: - Class marked `open` to preserve subclassability from Java/Kotlin - All non-final public/protected methods marked `open` to match Java virtual-by-default - `resolveView` and `resolveViewManager` remain `final` (matching the Java original) - `Nullable` return types converted to Kotlin nullable types (`?`) - `synchronized` methods use `Synchronized` annotation - Static initializer converted to companion object `init` block Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D104999732
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
May 20, 2026
Summary: Pull Request resolved: facebook#56828 Mechanical migration of the deprecated `NativeViewHierarchyManager` stub class from Java to Kotlin. All methods remain empty stubs — no behavioral changes. Key migration decisions: - Class marked `open` to preserve subclassability from Java/Kotlin - All non-final public/protected methods marked `open` to match Java virtual-by-default - `resolveView` and `resolveViewManager` remain `final` (matching the Java original) - `Nullable` return types converted to Kotlin nullable types (`?`) - `synchronized` methods use `Synchronized` annotation - Static initializer converted to companion object `init` block Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D104999732
cortinico
force-pushed
the
export-D104999732
branch
from
b845b54 to
7230c87
Compare
Summary: Pull Request resolved: facebook#56828 Mechanical migration of the deprecated `NativeViewHierarchyManager` stub class from Java to Kotlin. All methods remain empty stubs — no behavioral changes. Key migration decisions: - Class marked `open` to preserve subclassability from Java/Kotlin - All non-final public/protected methods marked `open` to match Java virtual-by-default - `resolveView` and `resolveViewManager` remain `final` (matching the Java original) - `Nullable` return types converted to Kotlin nullable types (`?`) - `synchronized` methods use `Synchronized` annotation - Static initializer converted to companion object `init` block Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D104999732
cortinico
force-pushed
the
export-D104999732
branch
from
7230c87 to
7617ba8
Compare
|
This pull request has been merged in c6dd6f9. |
Collaborator
|
This pull request was successfully merged by @cortinico in c6dd6f9 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Mechanical migration of the deprecated
NativeViewHierarchyManagerstub class from Java to Kotlin. All methods remain empty stubs — no behavioral changes.Key migration decisions:
opento preserve subclassability from Java/Kotlinopento match Java virtual-by-defaultresolveViewandresolveViewManagerremainfinal(matching the Java original)Nullablereturn types converted to Kotlin nullable types (?)synchronizedmethods useSynchronizedannotationinitblockChangelog:
[Internal]
Reviewed By: christophpurrer
Differential Revision: D104999732