Remove RCTCxxMethod (#56830)#56830
Closed
javache wants to merge 2 commits into
Closed
Conversation
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105168516. |
Summary: Fully remove the symbols for RCTCxxBridge when remove-legacy-arch is enabled. Changelog: [iOS][Breaking] Removing further legacy arch symbols such as RCTCxxBridge Reviewed By: christophpurrer Differential Revision: D105167968
Summary: This is part of the legacy arch, and the last usage of it in RCTCxxModule was removed in D81294192 Changelog: [iOS][Removed] Legacy arch removal: RCTCxxMethod and DispatchMessageQueueThread Reviewed By: christophpurrer Differential Revision: D105168516
e24446d to
d84f9fb
Compare
|
This pull request has been merged in 3b76474. |
Collaborator
|
This pull request was successfully merged by @javache in 3b76474 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is part of the legacy arch, and the last usage of it in RCTCxxModule was removed in D81294192
Changelog: [iOS][Removed] Legacy arch removal: RCTCxxMethod and DispatchMessageQueueThread
Reviewed By: christophpurrer
Differential Revision: D105168516