Remove enableFabricRenderer() call from InteropModuleRegistry#56852
Closed
mdvacca wants to merge 2 commits into
Closed
Remove enableFabricRenderer() call from InteropModuleRegistry#56852mdvacca wants to merge 2 commits into
mdvacca wants to merge 2 commits into
Conversation
facebook#56851) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. Inline `true` and simplify the surrounding `&&` expressions: - Two `if (enableFabricRenderer() && useFabricInterop())` checks become `if (useFabricInterop())`. - Remove the now-unused import. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105229106
Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. Production: - `checkReactFeatureFlagsConditions` now returns `useFabricInterop()` only. - Remove the now-unused `enableFabricRenderer` import. Test: - `overrideFeatureFlags` test helper drops the `enableFabricRenderer` parameter. - Existing test cases continue to exercise both true/false branches of `useFabricInterop`. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105229610
meta-cla
Bot
added
the
CLA Signed
|
@mdvacca has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105229610. |
|
This pull request has been merged in 3b9c581. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()flag is being deleted; it always returns true on the canary release stage.Production:
checkReactFeatureFlagsConditionsnow returnsuseFabricInterop()only.enableFabricRendererimport.Test:
overrideFeatureFlagstest helper drops theenableFabricRendererparameter.useFabricInterop.Behavior is unchanged.
Changelog:
[Internal]
Reviewed By: javache
Differential Revision: D105229610