Skip to content

Remove enableFabricRenderer() call from DefaultNewArchitectureEntryPoint (#56854) #56854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdvacca wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −8
Open

Remove enableFabricRenderer() call from DefaultNewArchitectureEntryPoint (#56854) #56854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions ...eactAndroid/src/main/java/com/facebook/react/defaults/DefaultNewArchitectureEntryPoint.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,7 @@ public object DefaultNewArchitectureEntryPoint {
internal fun loadWithFeatureFlags(featureFlags: ReactNativeFeatureFlagsProvider) {
ReactNativeFeatureFlags.override(featureFlags)

privateFabricEnabled = featureFlags.enableFabricRenderer()
privateTurboModulesEnabled = featureFlags.useTurboModules()
privateConcurrentReactEnabled = featureFlags.enableFabricRenderer()
privateBridgelessEnabled = featureFlags.enableBridgelessArchitecture()

val (isValid, errorMessage) =
Expand All @@ -134,9 +132,7 @@ public object DefaultNewArchitectureEntryPoint {

private var privateFabricEnabled: Boolean = false

@JvmStatic
public val fabricEnabled: Boolean
get() = privateFabricEnabled
@JvmStatic public val fabricEnabled: Boolean = true

private var privateTurboModulesEnabled: Boolean = false

Expand All @@ -146,9 +142,7 @@ public object DefaultNewArchitectureEntryPoint {

private var privateConcurrentReactEnabled: Boolean = false

@JvmStatic
public val concurrentReactEnabled: Boolean
get() = privateConcurrentReactEnabled
@JvmStatic public val concurrentReactEnabled: Boolean = true

private var privateBridgelessEnabled: Boolean = false

Expand Down
Loading