Skip to content

Inline true in ReactDelegate.isFabricEnabled initializer (#56859) #56859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdvacca wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Inline true in ReactDelegate.isFabricEnabled initializer (#56859) #56859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d590d3
Remove enableFabricRenderer() call from DefaultNewArchitectureEntryPo…
mdvacca May 15, 2026
2b501c0
Remove enableFabricRenderer() call from ReactInstanceManager (#56855)
mdvacca May 15, 2026
861ec44
Remove enableFabricRenderer() assertion from ReactHostImpl (#56856)
mdvacca May 15, 2026
363383b
Inline true in ReactActivityDelegate.isFabricEnabled() (#56857)
mdvacca May 15, 2026
41db94e
Inline true in ReactDelegate.isFabricEnabled initializer (#56859)
mdvacca May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ges/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ protected ReactActivity getReactActivity() {
* @return true if Fabric is enabled for this Activity, false otherwise.
*/
protected boolean isFabricEnabled() {
return ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer();
return true;
}

/**
Expand Down
4 changes: 1 addition & 3 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactDelegate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@ public open class ReactDelegate {
*
* @return true if Fabric is enabled for this Activity, false otherwise.
*/
protected var isFabricEnabled: Boolean =
ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()
private set
protected val isFabricEnabled: Boolean = true

/**
* Do not use this constructor as it's not accounting for New Architecture at all. You should use
Expand Down
3 changes: 0 additions & 3 deletions ...ages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
import com.facebook.react.interfaces.TaskInterface;
import com.facebook.react.internal.AndroidChoreographerProvider;
import com.facebook.react.internal.ChoreographerProvider;
import com.facebook.react.internal.featureflags.ReactNativeNewArchitectureFeatureFlags;
import com.facebook.react.modules.appearance.AppearanceModule;
import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
import com.facebook.react.modules.core.DeviceEventManagerModule;
Expand Down Expand Up @@ -320,8 +319,6 @@ public JavaScriptExecutorFactory getJavaScriptExecutorFactory() {
Activity currentActivity = getCurrentActivity();
if (currentActivity != null) {
ReactRootView rootView = new ReactRootView(currentActivity);
boolean isFabric = ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer();
rootView.setIsFabric(isFabric);
rootView.startReactApplication(ReactInstanceManager.this, appKey, new Bundle());
return rootView;
}
Expand Down
10 changes: 2 additions & 8 deletions ...eactAndroid/src/main/java/com/facebook/react/defaults/DefaultNewArchitectureEntryPoint.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,7 @@ public object DefaultNewArchitectureEntryPoint {
internal fun loadWithFeatureFlags(featureFlags: ReactNativeFeatureFlagsProvider) {
ReactNativeFeatureFlags.override(featureFlags)

privateFabricEnabled = featureFlags.enableFabricRenderer()
privateTurboModulesEnabled = featureFlags.useTurboModules()
privateConcurrentReactEnabled = featureFlags.enableFabricRenderer()
privateBridgelessEnabled = featureFlags.enableBridgelessArchitecture()

val (isValid, errorMessage) =
Expand All @@ -134,9 +132,7 @@ public object DefaultNewArchitectureEntryPoint {

private var privateFabricEnabled: Boolean = false

@JvmStatic
public val fabricEnabled: Boolean
get() = privateFabricEnabled
@JvmStatic public val fabricEnabled: Boolean = true

private var privateTurboModulesEnabled: Boolean = false

Expand All @@ -146,9 +142,7 @@ public object DefaultNewArchitectureEntryPoint {

private var privateConcurrentReactEnabled: Boolean = false

@JvmStatic
public val concurrentReactEnabled: Boolean
get() = privateConcurrentReactEnabled
@JvmStatic public val concurrentReactEnabled: Boolean = true

private var privateBridgelessEnabled: Boolean = false

Expand Down
5 changes: 0 additions & 5 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,11 +857,6 @@ public class ReactHostImpl(
"enableBridgelessArchitecture FeatureFlag must be set to start ReactNative.",
)

Assertions.assertCondition(
ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer(),
"enableFabricRenderer FeatureFlag must be set to start ReactNative.",
)

Assertions.assertCondition(
ReactNativeNewArchitectureFeatureFlags.useTurboModules(),
"useTurboModules FeatureFlag must be set to start ReactNative.",
Expand Down
Loading