fix(cocoapods): escape local file URIs for unicode paths#56907
Open
chrfalch wants to merge 1 commit into
Open
Conversation
## Summary #56878 shows that using unicode characters in paths fails with pod install. Expo fixed this internally here: expo/expo#45779 #fixes Unicode filesystem paths break iOS precompiled xcframework resolution due to unescaped URI handling Fixes #56878 ## How Build local file:// sources through a shared helper that percent-encodes filesystem paths before passing them to URI::File.build. This avoids Ruby/CocoaPods URI failures when React Native projects or local prebuilt tarballs live under paths containing Unicode characters or spaces. Apply the helper to RNCore and ReactNativeDependencies local tarball sources, including RNCore dSYM-processed prebuilt paths, while leaving remote Maven and Sonatype URLs unchanged. Add focused coverage for Unicode, spaces, ASCII paths, and the raw URI::File.build regression case.
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Expo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
#56878 shows that using unicode characters in paths fails with pod install.
Expo fixed this internally here: expo/expo#45779
Fixes #56878
How:
Build local
file://sources through a shared helper that percent-encodes filesystem paths before passing them toURI::File.build. This avoids Ruby/CocoaPods URI failures when React Native projects or local prebuilt tarballs live under paths containing Unicode characters or spaces.Apply the helper to
RNCoreandReactNativeDependencieslocal tarball sources, including RNCore dSYM-processed prebuilt paths, while leaving remote Maven and Sonatype URLs unchanged.Add focused coverage for Unicode, spaces, ASCII paths, and the raw
URI::File.buildregression case.Changelog:
[IOS] [FIXED] - fixed escaping local file URIs for unicode paths in ruby scripts
Test Plan: