Bump Kotlin compiler to 2.3.21#56920
Conversation
Summary: Upgrade the Kotlin compiler version in the project to the latest public stable release (2.3.21). Also bump the apiVersion to KOTLIN_2_1 in all four gradle-plugin build files to resolve deprecation warnings for 2.0, and replace the deprecated -Xjvm-default compiler option in ReactAndroid with -jvm-default=no-compatibility. ## Changelog: [ANDROID] [CHANGED] - Bumped Kotlin version to 2.3.21 and Kotlin API version to 2.1 TAG=agy CONV=2fc9825d-a86b-4fbb-ab9a-e7d467b57dd3
|
Hi @mcorner! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
I just saw: #56222. If that pull is going to happen, we don't need this, but one of them is needed to unblock our SDK wrapper for reCAPTCHA. |
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D105966180. |
|
Actually this change here: 62038cf is sufficient to unblock us (once it lands in some release). You can accept this if you want to go another version to 2.3.21 |
That landed on The branch cut for 0.86 happened earlier so, unless we cherry pick it, it won't be included in that release. I'll double-check internally whether we can make it. |
This can't be merged as is. React Native follows the same version of Kotlin that is used internally at Meta. What's the reason why you want this bump? We recently bumped to 2.2.0 which should be source compatible with 2.3 also. |
This will land in 0.87 as the window to pick this inside 0.86 has closed + 0.86 will have no breaking changes (and this Kotlin bump is breaking instead). |
Summary:
Upgrade the Kotlin compiler version in the project to the latest public stable release (2.3.21).
2.2.0to2.3.21in the central version catalogs ofreact-nativeandgradle-plugin.apiVersiontarget toKotlinVersion.KOTLIN_2_1in all fourgradle-pluginbuild files (shared,react-native-gradle-plugin,settings-plugin,shared-testutil) to resolve deprecation warnings for 2.0.-Xjvm-default=allcompiler option inReactAndroidwith-jvm-default=no-compatibilityto avoid compilation errors under Kotlin 2.3.21.Changelog:
[ANDROID] [CHANGED] - Bumped Kotlin version to 2.3.21 and Kotlin API version to 2.1
Test Plan:
Verified by running all local unit tests for both the Gradle plugin and the core Android library:
gradle-plugin):./gradlew testinpackages/gradle-plugin.API version 2.0deprecation warnings.ReactAndroid):./gradlew :packages:react-native:ReactAndroid:testin the root directory.-Xjvm-defaultdeprecation warnings.