Remove unreferenced ViewNativeComponentType#56943
Closed
huntie wants to merge 1 commit into
Closed
Conversation
Summary: Discovered while I try to understand the best shape for ref types. We have no other 1P component usage pattern for `React.ElementRef<ViewNativeComponentType>`, except for two now-removed fbsource instances, replaced with `React.ElementRef<typeof View>`. Changelog: [Internal] Differential Revision: D106093290
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106093290. |
cortinico
approved these changes
May 22, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @huntie in 0676eb6 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 0676eb6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Discovered while I try to understand the best shape for ref types.
We have no other 1P component usage pattern for
React.ElementRef<ViewNativeComponentType>, except for two now-removed fbsource instances, replaced withReact.ElementRef<typeof View>.Changelog: [Internal]
Differential Revision: D106093290