Cleanup enableVirtualViewDebugFeatures and FlingItemOverlay (#56946)#56946
Closed
javache wants to merge 1 commit into
Closed
Cleanup enableVirtualViewDebugFeatures and FlingItemOverlay (#56946)#56946javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105959433. |
…#56946) Summary: The `enableVirtualViewDebugFeatures` feature flag was effectively dead — its only MobileConfig backing param (`rn_fling.fling_debug`) hadn't been updated in 365+ days, and the codemod-tracking diff D105936405 was already queued to remove the three native overrides. Rather than carry the FF + JS overlay surface forward, delete the whole stack: the FF, the overrides, the BUCK dep, the JS overlay components (`FlingItemOverlay`, `FlingDebugItemOverlay`, `FlingDebugOverlay`), the debug-log helpers in the native ScrollView/VirtualView implementations on both iOS and Android, and the now-orphaned references in `VirtualCollectionView`. Net: 4 files deleted, the FF removed from the cross-language codegen, native debug logging dropped from 5 files (1 ObjC++, 4 Kotlin), and consumer code in `VirtualCollectionView` simplified. Changelog: [General][Removed] - Remove unused `enableVirtualViewDebugFeatures` feature flag and the associated `FlingItemOverlay` / `FlingDebugItemOverlay` debug surfaces. Reviewed By: lunaleaps Differential Revision: D105959433
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D105959433
branch
from
5d3aaaf to
cfd8907
Compare
Collaborator
|
This pull request was successfully merged by @javache in 083fd99 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 083fd99. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
enableVirtualViewDebugFeaturesfeature flag was effectively dead — its only MobileConfig backing param (rn_fling.fling_debug) hadn't been updated in 365+ days, and the codemod-tracking diff D105936405 was already queued to remove the three native overrides. Rather than carry the FF + JS overlay surface forward, delete the whole stack: the FF, the overrides, the BUCK dep, the JS overlay components (FlingItemOverlay,FlingDebugItemOverlay,FlingDebugOverlay), the debug-log helpers in the native ScrollView/VirtualView implementations on both iOS and Android, and the now-orphaned references inVirtualCollectionView.Net: 4 files deleted, the FF removed from the cross-language codegen, native debug logging dropped from 5 files (1 ObjC++, 4 Kotlin), and consumer code in
VirtualCollectionViewsimplified.Changelog:
[General][Removed] - Remove unused
enableVirtualViewDebugFeaturesfeature flag and the associatedFlingItemOverlay/FlingDebugItemOverlaydebug surfaces.Reviewed By: lunaleaps
Differential Revision: D105959433