Revert recent Flow syntax codemods in react-native-github (#56998)#56998
Closed
rubennorte wants to merge 1 commit into
Closed
Revert recent Flow syntax codemods in react-native-github (#56998)#56998rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106813102. |
rubennorte
force-pushed
the
export-D106813102
branch
from
1f9e28a to
0e2c88e
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2026
…6998) Summary: Pull Request resolved: facebook#56998 Reverts the codemod that replaced `+T` Flow variance annotations with the newer `out T` syntax across files in `packages/react-native` and `packages/react-native-codegen`. No runtime behavior changes; this is purely a Flow type-annotation revert. Changelog: [Internal] Differential Revision: D106813102
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D106813102
branch
from
0e2c88e to
e0120ee
Compare
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D106813102
branch
from
e0120ee to
343a033
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2026
…6998) Summary: Pull Request resolved: facebook#56998 Reverts the recent Flow syntax codemods applied across `packages/`, `private/`, and `scripts/` in react-native-github. Specifically restores the previous form for: - `+T` / `+Instance` style variance annotations on generic type parameters that had been converted to the newer `out T` / `in T` keyword form. - `+field:` covariant object/interface properties that had been converted to the `readonly field:` modifier form. - `+[K in keyof T]:` mapped-type covariance that had been converted to `readonly [K in keyof T]:`. These are purely Flow type-annotation changes with no runtime behavior impact, restoring the form that the rest of the toolchain (in particular Fantom) already supports. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D106813102
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D106813102
branch
from
343a033 to
623ba91
Compare
…6998) Summary: Pull Request resolved: facebook#56998 Reverts the recent Flow syntax codemods applied across `packages/`, `private/`, and `scripts/` in react-native-github. Specifically restores the previous form for: - `+T` / `+Instance` style variance annotations on generic type parameters that had been converted to the newer `out T` / `in T` keyword form. - `+field:` covariant object/interface properties that had been converted to the `readonly field:` modifier form. - `+[K in keyof T]:` mapped-type covariance that had been converted to `readonly [K in keyof T]:`. These are purely Flow type-annotation changes with no runtime behavior impact, restoring the form that the rest of the toolchain (in particular Fantom) already supports. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D106813102
rubennorte
force-pushed
the
export-D106813102
branch
from
623ba91 to
bd25689
Compare
|
This pull request has been merged in 833144f. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 833144f When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reverts the recent Flow syntax codemods applied across
packages/,private/, andscripts/in react-native-github. Specifically restores the previous form for:+T/+Instancestyle variance annotations on generic type parameters that had been converted to the newerout T/in Tkeyword form.+field:covariant object/interface properties that had been converted to thereadonly field:modifier form.+[K in keyof T]:mapped-type covariance that had been converted toreadonly [K in keyof T]:.These are purely Flow type-annotation changes with no runtime behavior impact, restoring the form that the rest of the toolchain (in particular Fantom) already supports.
Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D106813102