Fix accessibilityLabelledBy crash on empty array (#57029)#57029
Closed
rozele wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rozele has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107127388. |
meta-codesync
Bot
changed the title
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jun 1, 2026
Summary: Fixes a crash in `BaseViewManager.setAccessibilityLabelledBy` when an empty array is passed. The method now guards against accessing index 0 on empty arrays and properly clears the tag when null or empty arrays are provided, instead of leaving stale associations. ## Changelog [Android][Fixed] - Issue when clearing accessibilityLabelledBy Reviewed By: bvanderhoof Differential Revision: D107127388
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jun 1, 2026
Summary: Fixes a crash in `BaseViewManager.setAccessibilityLabelledBy` when an empty array is passed. The method now guards against accessing index 0 on empty arrays and properly clears the tag when null or empty arrays are provided, instead of leaving stale associations. ## Changelog [Android][Fixed] - Issue when clearing accessibilityLabelledBy Reviewed By: bvanderhoof Differential Revision: D107127388
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jun 1, 2026
Summary: Fixes a crash in `BaseViewManager.setAccessibilityLabelledBy` when an empty array is passed. The method now guards against accessing index 0 on empty arrays and properly clears the tag when null or empty arrays are provided, instead of leaving stale associations. ## Changelog [Android][Fixed] - Issue when clearing accessibilityLabelledBy Reviewed By: bvanderhoof Differential Revision: D107127388
Summary: Fixes a crash in `BaseViewManager.setAccessibilityLabelledBy` when an empty array is passed. The method now guards against accessing index 0 on empty arrays and properly clears the tag when null or empty arrays are provided, instead of leaving stale associations. ## Changelog [Android][Fixed] - Issue when clearing accessibilityLabelledBy Reviewed By: bvanderhoof Differential Revision: D107127388
|
This pull request has been merged in 63dec77. |
Collaborator
|
This pull request was successfully merged by @rozele in 63dec77 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes a crash in
BaseViewManager.setAccessibilityLabelledBywhen an empty array is passed. The method now guards against accessing index 0 on empty arrays and properly clears the tag when null or empty arrays are provided, instead of leaving stale associations.Changelog
[Android][Fixed] - Issue when clearing accessibilityLabelledBy
Reviewed By: bvanderhoof
Differential Revision: D107127388