Remove NativeDialogManagerAndroid API (#57047)#57047
Closed
huntie wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107250968. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
cortinico
approved these changes
Jun 2, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jun 2, 2026
Summary: **Motivation** `NativeDialogManagerAndroid` is an internal native module used by `Alert` and `PermissionsAndroid` on Android, not an intended root React Native public API. **Notes** - `NativeDialogManagerAndroid` wasn't defined on our manual public TypeScript types — so was never discoverable via TypeScript auto-import. - Appears unused by open source consumers with public code on GitHub ([search](https://github.com/search?type=code&q=NativeDialogManagerAndroid++NOT+is%3Aarchived+NOT+is%3Afork+language%3ATypeScript&l=TypeScript⁄)). Changelog: [General][Breaking] - The `NativeDialogManagerAndroid` export is removed. Reviewed By: cortinico Differential Revision: D107250968
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jun 2, 2026
Summary: **Motivation** `NativeDialogManagerAndroid` is an internal native module used by `Alert` and `PermissionsAndroid` on Android, not an intended root React Native public API. **Notes** - `NativeDialogManagerAndroid` wasn't defined on our manual public TypeScript types — so was never discoverable via TypeScript auto-import. - Appears unused by open source consumers with public code on GitHub ([search](https://github.com/search?type=code&q=NativeDialogManagerAndroid++NOT+is%3Aarchived+NOT+is%3Afork+language%3ATypeScript&l=TypeScript⁄)). Changelog: [General][Breaking] - The `NativeDialogManagerAndroid` export is removed. Reviewed By: cortinico Differential Revision: D107250968
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jun 2, 2026
Summary: Pull Request resolved: facebook#57047 **Motivation** `NativeDialogManagerAndroid` is an internal native module used by `Alert` and `PermissionsAndroid` on Android, not an intended root React Native public API. **Notes** - `NativeDialogManagerAndroid` wasn't defined on our manual public TypeScript types — so was never discoverable via TypeScript auto-import. - Appears unused by open source consumers with public code on GitHub ([search](https://github.com/search?type=code&q=NativeDialogManagerAndroid++NOT+is%3Aarchived+NOT+is%3Afork+language%3ATypeScript&l=TypeScript⁄)). Changelog: [General][Breaking] - The `NativeDialogManagerAndroid` export is removed. Differential Revision: D107250968
Summary: Add `pointerEvents` to `TextProps` in the Flow source. This prop is supported at the native layer — `BaseParagraphProps` (the C++ props struct for Text/Paragraph) extends `ViewProps`, which includes `pointerEvents`. The old hand-written TypeScript types (`Text.d.ts`) already declared this prop, but the Flow source did not, causing a gap in the auto-generated strict API types (`types_generated`). Changelog: [General][Fixed] - **Strict TypeScript API**: Add missing `pointerEvents` prop to `Text` component Reviewed By: cortinico Differential Revision: D106183960
Summary: **Motivation** `NativeDialogManagerAndroid` is an internal native module used by `Alert` and `PermissionsAndroid` on Android, not an intended root React Native public API. **Notes** - `NativeDialogManagerAndroid` wasn't defined on our manual public TypeScript types — so was never discoverable via TypeScript auto-import. - Appears unused by open source consumers with public code on GitHub ([search](https://github.com/search?type=code&q=NativeDialogManagerAndroid++NOT+is%3Aarchived+NOT+is%3Afork+language%3ATypeScript&l=TypeScript⁄)). Changelog: [General][Breaking] - The `NativeDialogManagerAndroid` export is removed. Reviewed By: cortinico Differential Revision: D107250968
meta-codesync
Bot
changed the title
|
This pull request has been merged in a793d21. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation
NativeDialogManagerAndroidis an internal native module used byAlertandPermissionsAndroidon Android, not an intended root React Native public API.Notes
NativeDialogManagerAndroidwasn't defined on our manual public TypeScript types — so was never discoverable via TypeScript auto-import.Changelog:
[General][Breaking] - The
NativeDialogManagerAndroidexport is removed.Reviewed By: cortinico
Differential Revision: D107250968