Skip to content

Deprecate RCTTurboModuleEnabled() and RCTEnableTurboModule() (#57082) #57082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christophpurrer wants to merge 1 commit into from
+7 −7
Closed

Deprecate RCTTurboModuleEnabled() and RCTEnableTurboModule() (#57082) #57082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-native/Libraries/AppDelegate/RCTReactNativeFactory.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ - (instancetype)initWithDelegate:(id<RCTReactNativeFactoryDelegate>)delegate rel
[self _setUpFeatureFlags:releaseLevel];

[RCTColorSpaceUtils applyDefaultColorSpace:[self defaultColorSpace]];
RCTEnableTurboModule(YES);

self.rootViewFactory = [self createRCTRootViewFactory];

Expand Down
10 changes: 6 additions & 4 deletions packages/react-native/React/Base/RCTBridge.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,13 @@ NSString *RCTBridgeModuleNameForClass(Class bridgeModuleClass);
NSMutableArray<NSString *> *getModulesLoadedWithOldArch(void);

/**
* Experimental.
* Check/set if JSI-bound NativeModule is enabled. By default it's off.
* The New Architecture is enabled by default. These APIs are no-ops and will
* be removed in a future release.
*/
BOOL RCTTurboModuleEnabled(void);
void RCTEnableTurboModule(BOOL enabled);
BOOL RCTTurboModuleEnabled(void)
__attribute__((deprecated("TurboModules are always enabled; this always returns YES (NO in test env).")));
void RCTEnableTurboModule(BOOL enabled)
__attribute__((deprecated("No-op. The New Architecture is enabled by default.")));

#ifndef RCT_REMOVE_LEGACY_MODULE_INTEROP
// Turn on TurboModule interop
Expand Down
3 changes: 1 addition & 2 deletions packages/react-native/React/Base/RCTBridge.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ void RCTRegisterModule(Class moduleClass)
return RCTDropReactPrefixes(name);
}

static const BOOL turboModuleEnabled = YES;
BOOL RCTTurboModuleEnabled(void)
{
#if RCT_DEBUG
Expand All @@ -191,7 +190,7 @@ BOOL RCTTurboModuleEnabled(void)
return NO;
}
#endif
return turboModuleEnabled;
return YES;
}

void RCTEnableTurboModule(BOOL enabled)
Expand Down
Loading