Skip to content

Replace object getter with Object.defineProperty in TestRenderer #10473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flarnie merged 4 commits into from
Aug 17, 2017
Merged

Replace object getter with Object.defineProperty in TestRenderer #10473

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
962e70a
Add babel transform for object getters
flarnie Aug 16, 2017
f04a4dc
Replace object getter with `Object.defineProperty` in TestRenderer
flarnie Aug 16, 2017
f150345
Tweak the Object.defineProperty call in test renderer to make flow pass
flarnie Aug 16, 2017
1811c3c
More flow type tweaking
flarnie Aug 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions src/renderers/testing/ReactTestRendererFiberEntry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,13 +565,9 @@ var ReactTestRendererFiber = {
invariant(root != null, 'something went wrong');
TestRenderer.updateContainer(element, root, null, null);

return {
get root() {
if (root === null || root.current.child === null) {
throw new Error("Can't access .root on unmounted test renderer");
}
return wrapFiber(root.current.child);
},
var entry = {
root: undefined, // makes flow happy
// we define a 'getter' for 'root' below using 'Object.defineProperty'
toJSON() {
if (root == null || root.current == null || container == null) {
return null;
Expand Down Expand Up @@ -611,6 +607,23 @@ var ReactTestRendererFiber = {
return TestRenderer.getPublicRootInstance(root);
},
};

Object.defineProperty(
entry,
'root',
({
configurable: true,
enumerable: true,
get: function() {
if (root === null || root.current.child === null) {
throw new Error("Can't access .root on unmounted test renderer");
}
return wrapFiber(root.current.child);
},
}: Object),
);

return entry;
},

/* eslint-disable camelcase */
Expand Down