Skip to content

Conversation

@robhrt7
Copy link
Contributor

@robhrt7 robhrt7 commented Aug 18, 2017

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Format your code with prettier (npm run prettier).
  6. Make sure your code lints (npm run lint).
  7. Run the Flow typechecks (npm run flow).
  8. If you haven't already, complete the CLA.

@robhrt7
Copy link
Contributor Author

robhrt7 commented Sep 4, 2017

Anyone? No breaking change, I promise :)

@robhrt7
Copy link
Contributor Author

robhrt7 commented Sep 7, 2017

Resolved conflicts

@robhrt7
Copy link
Contributor Author

robhrt7 commented Sep 7, 2017

I see other PR's with conference additions are getting merged before this one (#10614), looks discriminating. Can anybody have a look at this as well?

@robhrt7
Copy link
Contributor Author

robhrt7 commented Sep 7, 2017

cc @nhunzaker

@nhunzaker
Copy link
Contributor

Looks good. Sorry for the delay. Working through the queue as fast as I can :)

@robhrt7
Copy link
Contributor Author

robhrt7 commented Sep 7, 2017

Thanks a lot, @nhunzaker!

flarnie pushed a commit to flarnie/react that referenced this pull request Sep 8, 2017
gaearon pushed a commit that referenced this pull request Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants