Live code editor ignores tab key for improved a11y#10992
Merged
bvaughn merged 1 commit intofacebook:masterfrom Oct 3, 2017
Merged
Live code editor ignores tab key for improved a11y#10992bvaughn merged 1 commit intofacebook:masterfrom
bvaughn merged 1 commit intofacebook:masterfrom
Conversation
|
Deploy preview ready! Built with commit adf7512 |
Contributor
Author
|
Meh. This is uncontroversial and 3 days is probably long enough to let it sit. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10976
Note that the use of
ignoreTabKeycurrently triggers a DOM warning due toreact-livebut I will follow up with an upstream fix (see FormidableLabs/react-live/pull/40).