[WIP] no more vars on packages#11736
Closed
raphamorim wants to merge 13 commits intofacebook:masterfrom
Closed
Conversation
raphamorim
force-pushed
the
no-more-vars-on-packages
branch
from
aaffa04 to
df25386
Compare
raphamorim
force-pushed
the
no-more-vars-on-packages
branch
from
2f1557b to
f9ca024
Compare
Collaborator
|
I've already prepared a change to some files in ReactDOM that I plan to land tomorrow so this might need to wait and be fixed up later. |
Contributor
Author
|
Ok, thanks for the advice. Tomorrow I rebase from your changes and finish it. |
raphamorim
force-pushed
the
no-more-vars-on-packages
branch
from
d4da334 to
7c0d68e
Compare
Closed
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing remaining
varsREF: #11732
Removed entirely: