Closed
Conversation
12 tasks
raphamorim
force-pushed
the
remove-var
branch
from
17b60c9 to
6ee7b7d
Compare
gaearon
requested changes
Dec 3, 2017
| checked={true} | ||
| onChange={() => {}} | ||
| /> | ||
| <input type="checkbox" ref={n => (this.b = n)} checked={true} /> |
Collaborator
There was a problem hiding this comment.
This is undoing a recently merged change.
Contributor
Author
There was a problem hiding this comment.
damn, you're right. I'll solve it, can you continue review the other files?
I had conflict only with this file and the ReactFiber of reconciler package
raphamorim
force-pushed
the
remove-var
branch
3 times, most recently
from
5cc2d2a to
d61ed65
Compare
raphamorim
force-pushed
the
remove-var
branch
from
d61ed65 to
a096c77
Compare
Contributor
Author
|
Hm, I discovery other inconsistencies @gaearon (my mistake 😞 ) |
raphamorim
force-pushed
the
remove-var
branch
3 times, most recently
from
e7d5217 to
51c4f3e
Compare
raphamorim
force-pushed
the
remove-var
branch
from
51c4f3e to
006d900
Compare
Contributor
Author
|
Fixed @gaearon |
Collaborator
|
Sorry, I merged a few things and it's out of date again. Maybe we can split this further? |
Contributor
Author
|
Sure, I break in other Pull Requests. |
Merged
This was referenced Dec 5, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #11736