-
Notifications
You must be signed in to change notification settings - Fork 50.1k
Fix bug #1919 #8274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug #1919 #8274
Conversation
… as an argument to oneOf checker
… as an argument to oneOf checker
… bugfix/1919 # Conflicts: # src/isomorphic/classic/types/ReactPropTypes.js
|
I wanted to increase test coverage, but got a bunch of such errors... What can I do with it...? |
|
Thanks for the PR @wojtekmaj. We actually already have a pending PR for this #8274 |
|
Haha, sorry about that, had the wrong link in my clipboard 😄 #7526 is indeed what I meant.
Help is always welcome! Typically I like to treat it as first-come-first-serve, so people who make the effort first get a fair chance to get their contribution merged. @gaearon looks to have done some initial review of another related PR (#6940) so I'll defer to him. |
|
PropTypes have been removed from React core and now exist as a separate package Sorry about that @wojtekmaj! |
Added a warning when an array of PropTypes was supplied to as an argument to oneOf checker.
All PropType checkers now have a flag isReactTypeChecker that enables us to easily identify them later on.