Skip to content

Conversation

@wojtekmaj
Copy link

Added a warning when an array of PropTypes was supplied to as an argument to oneOf checker.

All PropType checkers now have a flag isReactTypeChecker that enables us to easily identify them later on.

… bugfix/1919

# Conflicts:
#	src/isomorphic/classic/types/ReactPropTypes.js
@wojtekmaj
Copy link
Author

I wanted to increase test coverage, but got a bunch of such errors...

FAIL  src\renderers\shared\fiber\__tests__\ReactCoroutine-test.js
  ● Test suite failed to run

    SyntaxError: Invalid regular expression: /\__tests__\/: \ at end of pattern
        at RegExp (native)

      at new Runtime (node_modules\jest-runtime\build\index.js:111:23)
      at handle (node_modules\worker-farm\lib\child\index.js:41:8)
      at process.<anonymous> (node_modules\worker-farm\lib\child\index.js:47:3)
      at emitTwo (events.js:106:13)
      at process.emit (events.js:191:7)
      at process.nextTick (internal\child_process.js:744:12)
      at _combinedTickCallback (internal\process\next_tick.js:67:7)


Test Summary
 › Ran all tests.
 › 124 test suites failed, 0 tests passed (0 total in 124 test suites, run time 5.274s)

What can I do with it...?

@aweary
Copy link
Contributor

aweary commented Nov 12, 2016

Thanks for the PR @wojtekmaj. We actually already have a pending PR for this #8274

@wojtekmaj
Copy link
Author

wojtekmaj commented Nov 12, 2016

Hey, but THIS is #8274 ;) You probably meant #7526. Well, I hope it can be of some help though! It seem like my idea is a little simpler (whether it's better, I'm not the one to decide).

@aweary
Copy link
Contributor

aweary commented Nov 12, 2016

Haha, sorry about that, had the wrong link in my clipboard 😄 #7526 is indeed what I meant.

Well, I hope it can be of some help though! It seem like my idea is a little simpler (whether it's better, I'm not the one to decide).

Help is always welcome! Typically I like to treat it as first-come-first-serve, so people who make the effort first get a fair chance to get their contribution merged. @gaearon looks to have done some initial review of another related PR (#6940) so I'll defer to him.

@aweary
Copy link
Contributor

aweary commented Apr 9, 2017

PropTypes have been removed from React core and now exist as a separate package prop-types. Any future feature requests, bug reports, or changes should be directed to the new repo at https://github.com/reactjs/prop-types.

Sorry about that @wojtekmaj!

@aweary aweary closed this Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants