Skip to content

[Fiber][WIP] Support React DevTools#8807

Closed
gaearon wants to merge 1 commit intomasterfrom
fiber-devtools
Closed

[Fiber][WIP] Support React DevTools#8807
gaearon wants to merge 1 commit intomasterfrom
fiber-devtools

Conversation

@gaearon
Copy link
Copy Markdown
Collaborator

@gaearon gaearon commented Jan 17, 2017

My first attempt. It seems to be working.

screen shot 2017-01-17 at 00 07 47

I diff trees on every commit to keep the implementation simple but we might hit performance limits with this. I'll be testing performance on Facebook products tomorrow.

I put the implementation inside React so that DevTools can stop depending on the internal field format. This makes it easier both for us to change the internals (for example, if we later decide to change the strategy), and for libraries like Preact/Infero (hi @trueadm @developit) to integrate with DevTools.

Some things are intentionally missing:

  • DOM highlighting
  • Jumping to the React element from Elements node
  • Support for Fiber-specific features like fragments
  • Cleaner data structure API
  • Flow / lint

I want to come back to them after making sure this approach is viable perf-wise.

Related DevTools PR: facebook/react-devtools#473. If you want to try it out, build React, check out DevTools at that branch, and copy the built React packages into its node_modules. The plain shell is the best for experimenting. If you change anything in React you'll need to recompile this folder by running ../../node_modules/.bin/webpack in it.

@gaearon
Copy link
Copy Markdown
Collaborator Author

gaearon commented Jan 17, 2017

Superseded by #8818.

@gaearon gaearon closed this Jan 17, 2017
@gaearon gaearon deleted the fiber-devtools branch January 17, 2017 20:46
@ghost
Copy link
Copy Markdown

ghost commented Jan 18, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants