Closed
Conversation
This was referenced Jan 17, 2017
Collaborator
Author
|
Superseded by #8818. |
|
hey what to do now?
17.01.2017 21:47 "Dan Abramov" <notifications@github.com> napisał(a):
… Closed #8807 <#8807>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8807 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AXwKLkHwu4JuHoQLdpXxRmP6rEbaI-_vks5rTSjwgaJpZM4LlGc_>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My first attempt. It seems to be working.
I diff trees on every commit to keep the implementation simple but we might hit performance limits with this. I'll be testing performance on Facebook products tomorrow.
I put the implementation inside React so that DevTools can stop depending on the internal field format. This makes it easier both for us to change the internals (for example, if we later decide to change the strategy), and for libraries like Preact/Infero (hi @trueadm @developit) to integrate with DevTools.
Some things are intentionally missing:
I want to come back to them after making sure this approach is viable perf-wise.
Related DevTools PR: facebook/react-devtools#473. If you want to try it out, build React, check out DevTools at that branch, and copy the built React packages into its
node_modules. The plain shell is the best for experimenting. If you change anything in React you'll need to recompile this folder by running../../node_modules/.bin/webpackin it.