Move 'lighthouse' and 'nodegit' to 'optionalDependencies'#9675
Merged
flarnie merged 1 commit intofacebook:masterfrom May 12, 2017
Merged
Move 'lighthouse' and 'nodegit' to 'optionalDependencies'#9675flarnie merged 1 commit intofacebook:masterfrom
flarnie merged 1 commit intofacebook:masterfrom
Conversation
**what is the change?:** See title. **why make this change?:** Both these dependencies were causing issues when working on React internally at FB. 'lighthouse' requires node >=6 and we don't want to folks working on React to using that version of node. https://github.com/GoogleChrome/lighthouse/blob/master/package.json#L11 'nodegit' for me throws an error related to libssh2 and it's annoying to make this work in every OS. See nodegit/nodegit#1266 **test plan:** `npm/yarn install` Runs with no errors on my CentOS machine and also on MacOSX laptop. **issue:** This is blocking work related to facebook#9398
trueadm
approved these changes
May 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what is the change?:
See title.
why make this change?:
Both these dependencies were causing issues when working on React internally at
FB.
'lighthouse' requires node >=6 and we don't want to folks working on React to
using that version of node.
https://github.com/GoogleChrome/lighthouse/blob/master/package.json#L11
'nodegit' for me throws an error related to libssh2 and it's annoying to make
this work in every OS. See nodegit/nodegit#1266
test plan:
npm/yarn installRuns with no errors on my CentOS machine and also on MacOSX laptop.
issue:
This is blocking work related to #9398