Skip to content

Fix externalization of 'lowPriorityWarning' in fb builds #9790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flarnie merged 1 commit into from
May 26, 2017
Merged

Fix externalization of 'lowPriorityWarning' in fb builds #9790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/rollup/modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,11 @@ function createModuleMap(paths, extractErrors, bundleType) {
moduleMap[moduleName] = resolve(file);
});
});
// if this is FB, we want to remove ReactCurrentOwner, so we can
// handle it with a different case
// if this is FB, we want to remove ReactCurrentOwner and lowPriorityWarning,
// so we can handle it with a different case
if (bundleType === FB_DEV || bundleType === FB_PROD) {
delete moduleMap.ReactCurrentOwner;
delete moduleMap.lowPriorityWarning;
}
return moduleMap;
}
Expand Down Expand Up @@ -120,6 +121,7 @@ function ignoreFBModules() {
// In FB bundles, we preserve an inline require to ReactCurrentOwner.
// See the explanation in FB version of ReactCurrentOwner in www:
'ReactCurrentOwner',
'lowPriorityWarning',
];
}

Expand Down
12 changes: 6 additions & 6 deletions scripts/rollup/results.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,16 @@
"gzip": 3614
},
"React-dev.js (FB_DEV)": {
"size": 74115,
"gzip": 18980
"size": 71806,
"gzip": 18233
},
"React-prod.js (FB_PROD)": {
"size": 36847,
"gzip": 9254
"size": 36172,
"gzip": 9226
},
"ReactDOMStack-dev.js (FB_DEV)": {
"size": 497678,
"gzip": 119007
"size": 495315,
"gzip": 118265
},
"ReactDOMStack-prod.js (FB_PROD)": {
"size": 353140,
Expand Down