Skip to content

Use multiarch to test 32 bit build #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xuhdev wants to merge 4 commits into from
Closed

Use multiarch to test 32 bit build #945

xuhdev wants to merge 4 commits into from

Conversation

@xuhdev
Copy link
Member

@xuhdev xuhdev commented Jun 21, 2025

Differential Revision: D77066796

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Use multiarch to test 32 bit build (facebook#945)
8c471a7 
Summary:



Rollback Plan:

Differential Revision: D77066796
@xuhdev xuhdev force-pushed the export-D77066796 branch from 27484d5 to 8c471a7 Compare June 21, 2025 05:46
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Use multiarch to test 32 bit build (facebook#945)
17549af 
Summary:



Rollback Plan:

Differential Revision: D77066796
@xuhdev xuhdev force-pushed the export-D77066796 branch from 8c471a7 to 17549af Compare June 21, 2025 05:51
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Use multiarch to test 32 bit build (facebook#945)
1d169a7 
Summary:



Rollback Plan:

Differential Revision: D77066796
@xuhdev xuhdev force-pushed the export-D77066796 branch from 17549af to 1d169a7 Compare June 21, 2025 05:53
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Use multiarch to test 32 bit build (facebook#945)
ccdbfcc 
Summary:



Rollback Plan:

Differential Revision: D77066796
@xuhdev xuhdev force-pushed the export-D77066796 branch from 1d169a7 to ccdbfcc Compare June 21, 2025 06:01
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Test 32 bit build with Debian multiarch (facebook#945)
a693714 
Summary:



Rollback Plan:

Differential Revision: D77066796
@xuhdev xuhdev force-pushed the export-D77066796 branch from ccdbfcc to a693714 Compare June 21, 2025 06:12
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Test 32 bit build with Debian multiarch (facebook#945)
50a2392 
Summary: Pull Request resolved: facebook#945

Differential Revision: D77066796
@xuhdev xuhdev force-pushed the export-D77066796 branch from a693714 to 50a2392 Compare June 21, 2025 06:18
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

@xuhdev xuhdev force-pushed the export-D77066796 branch from 50a2392 to a66f06a Compare June 21, 2025 06:23
xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Bring back 32 bit test to test type sizes (facebook#945)
a66f06a 
Summary:
Do so by use Debian's multiarch.


Differential Revision: D77066796
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Bring back 32 bit test to test type sizes (facebook#945)
7620972 
Summary:
Do so by use Debian's multiarch.


Differential Revision: D77066796
@xuhdev xuhdev force-pushed the export-D77066796 branch from a66f06a to 7620972 Compare June 21, 2025 06:31
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

@xuhdev xuhdev force-pushed the export-D77066796 branch from 7620972 to 83e1644 Compare June 21, 2025 06:58
xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Bring back 32 bit test to test type sizes (facebook#945)
83e1644 
Summary:
Do so by use Debian's multiarch.


Differential Revision: D77066796
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

@xuhdev xuhdev force-pushed the export-D77066796 branch from b21bace to b88e0e3 Compare June 21, 2025 08:17
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

@xuhdev xuhdev force-pushed the export-D77066796 branch from b88e0e3 to 5a12694 Compare June 21, 2025 08:40
xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Bring back 32 bit test to test type sizes (facebook#945)
5a12694 
Summary:
Do so by use Debian's multiarch.


Differential Revision: D77066796
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Bring back 32 bit test to test type sizes (facebook#945)
e38b8d5 
Summary:
Do so by use Debian's multiarch.


Differential Revision: D77066796
@xuhdev xuhdev force-pushed the export-D77066796 branch from 5a12694 to e38b8d5 Compare June 21, 2025 18:20
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Bring back 32 bit test to test type sizes (facebook#945)
f64967c 
Summary:
Do so by use Debian's multiarch.


Differential Revision: D77066796
@xuhdev xuhdev force-pushed the export-D77066796 branch from e38b8d5 to f64967c Compare June 21, 2025 18:26
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Bring back 32 bit test to test type sizes (facebook#945)
d0ef691 
Summary:
Do so by use Debian's multiarch.


Differential Revision: D77066796
@xuhdev xuhdev force-pushed the export-D77066796 branch from f64967c to d0ef691 Compare June 21, 2025 18:38
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

@xuhdev xuhdev force-pushed the export-D77066796 branch from d0ef691 to a9f75f7 Compare June 21, 2025 19:36
xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Bring back 32 bit test to test type sizes (facebook#945)
a9f75f7 
Summary:
Do so by use Debian's multiarch.


Differential Revision: D77066796
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

xuhdev added a commit to xuhdev/redex that referenced this pull request Jun 21, 2025
@xuhdev @facebook-github-bot
Bring back 32 bit test to test type sizes (facebook#945)
48ff743 
Summary:
Do so by use Debian's multiarch.


Differential Revision: D77066796
@xuhdev xuhdev force-pushed the export-D77066796 branch from a9f75f7 to 48ff743 Compare June 21, 2025 21:00
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

xuhdev added 4 commits June 21, 2025 14:39
@xuhdev @facebook-github-bot
Run popd twice in install_googletest_from_source
ffb225c 
Summary: `install_googletest_from_source` runs `pushd` twice.

Differential Revision: D77061401
@xuhdev @facebook-github-bot
Use oneof_value_case instead of has_* for oneof in proto
ecbe5a1 
Summary: The `has_*` functions are incompatible with protobuf 3.12.4, which we support. We have lost coverage over this protobuf version last month and thus did not catch this.

Differential Revision: D77064095
@xuhdev @facebook-github-bot
Use containers Debian 11/12, Ubuntu 22.04/24.04 for github actions (f…
cb8fff0 
…acebook#943)

Summary:
This makes all supported distros being tested.

- Stick to JDK 17 in Ubuntu 24.04, because Ubuntu 24.04 defaults to JDK 21, which requries source target 8, which fails some tests. (We don't yet support JDK 21)
- Build GoogleTest with `-std=gnu++17` to make sure `string_view` matchers are enabled on older versions of GCC. These matchers are now being used by some tests.


Differential Revision: D77059596
@xuhdev @facebook-github-bot
Bring back 32 bit test to test type sizes (facebook#945)
e1f633f 
Summary:
Do so by use Debian's multiarch.


Differential Revision: D77066796
@xuhdev xuhdev force-pushed the export-D77066796 branch from 48ff743 to e1f633f Compare June 21, 2025 21:39
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 21, 2025

This pull request was exported from Phabricator. Differential Revision: D77066796

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 23, 2025

This pull request has been merged in 07454ca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xuhdev @facebook-github-bot