Improved DX for working on Relay as non-FB dev#2749
Improved DX for working on Relay as non-FB dev#2749alloy wants to merge 7 commits intofacebook:masterfrom
Conversation
|
Ok, I ended up reverting this somewhat. Now we do perform a build on |
| "repository": "facebook/relay", | ||
| "scripts": { | ||
| "build": "gulp", | ||
| "build": "gulp dist", |
There was a problem hiding this comment.
This will now perform incremental builds, so running yarn install after a git pull will be faster.
| "jest": "NODE_ENV=test jest \"$@\"", | ||
| "lint": "eslint --max-warnings 0 .", | ||
| "prepublish": "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json && npm run build", | ||
| "postinstall": "npm run build", |
There was a problem hiding this comment.
This triggers the build after yarn install.
| "lint": "eslint --max-warnings 0 .", | ||
| "prepublish": "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json && npm run build", | ||
| "postinstall": "npm run build", | ||
| "prepublishOnly": "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json && npm run build:clean", |
There was a problem hiding this comment.
This only runs when actually invoking npm publish and will perform a clean before the build.
alloy
changed the title
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
2 participants
yarn install.yarn build:watchtask which leaves thedistdir in tact, which makesyarn linkwork and allows for easy integration into the dev’s project.yarn buildandyarn build:watch.