Skip to content

Add rocksdb_open_for_read_only to C API#130

Merged
igorcanadi merged 1 commit into
facebook:masterfrom
donovanhide:master
Apr 28, 2014
Merged

Add rocksdb_open_for_read_only to C API#130
igorcanadi merged 1 commit into
facebook:masterfrom
donovanhide:master

Conversation

@donovanhide
Copy link
Copy Markdown

No description provided.

@igorcanadi
Copy link
Copy Markdown
Contributor

Tnx for the contribution! Our max character per line limit is 80. Please shorten the long line. I believe you can do that by just calling make format.

@donovanhide
Copy link
Copy Markdown
Author

Hi, unfortunately there's no easy way that I know of to install clang-format itself on OS X Mavericks. Do you have any tips? If not, can you run the formatting on my behalf :-)

Cheers,
Donovan.

@igorcanadi
Copy link
Copy Markdown
Contributor

I believe you get clang-format if you install Xcode command-line tools.

I can do it now, sure :)

igorcanadi added a commit that referenced this pull request Apr 28, 2014
Add rocksdb_open_for_read_only to C API
@igorcanadi igorcanadi merged commit 7ca06a3 into facebook:master Apr 28, 2014
@donovanhide
Copy link
Copy Markdown
Author

Strange, it doesn't come up in may path and I have Xcode command line tools installed:

$which clang
/usr/bin/clang
$clang --version
Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn)
Target: x86_64-apple-darwin13.1.0
Thread model: posix
$ git diff -U0 HEAD^ | clang-format-diff.py
Traceback (most recent call last):
  File "/Users/donovanhide/bin/clang-format-diff.py", line 115, in <module>
    main()
  File "/Users/donovanhide/bin/clang-format-diff.py", line 98, in main
    stderr=None, stdin=subprocess.PIPE)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1308, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

The error due to it not finding clang-format

Anyway, thanks for merging :-)

abbccdda pushed a commit to abbccdda/rocksdb that referenced this pull request Jul 15, 2021
Nazgolze pushed a commit to Nazgolze/rocksdb-1 that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants