Add rocksdb_open_for_read_only to C API#130
Merged
Merged
Conversation
Contributor
|
Tnx for the contribution! Our max character per line limit is 80. Please shorten the long line. I believe you can do that by just calling |
Author
|
Hi, unfortunately there's no easy way that I know of to install clang-format itself on OS X Mavericks. Do you have any tips? If not, can you run the formatting on my behalf :-) Cheers, |
Contributor
|
I believe you get clang-format if you install Xcode command-line tools. I can do it now, sure :) |
igorcanadi
added a commit
that referenced
this pull request
Apr 28, 2014
Add rocksdb_open_for_read_only to C API
Author
|
Strange, it doesn't come up in may path and I have Xcode command line tools installed: $which clang
/usr/bin/clang
$clang --version
Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn)
Target: x86_64-apple-darwin13.1.0
Thread model: posix
$ git diff -U0 HEAD^ | clang-format-diff.py
Traceback (most recent call last):
File "/Users/donovanhide/bin/clang-format-diff.py", line 115, in <module>
main()
File "/Users/donovanhide/bin/clang-format-diff.py", line 98, in main
stderr=None, stdin=subprocess.PIPE)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 711, in __init__
errread, errwrite)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1308, in _execute_child
raise child_exception
OSError: [Errno 2] No such file or directoryThe error due to it not finding clang-format Anyway, thanks for merging :-) |
abbccdda
pushed a commit
to abbccdda/rocksdb
that referenced
this pull request
Jul 15, 2021
Nazgolze
pushed a commit
to Nazgolze/rocksdb-1
that referenced
this pull request
Sep 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.