db_impl.h: DBImpl::PreprocessWrite: Remove "REQUIRES: mutex locked"#13290
Open
evanj wants to merge 1 commit intofacebook:mainfrom
Open
db_impl.h: DBImpl::PreprocessWrite: Remove "REQUIRES: mutex locked"#13290evanj wants to merge 1 commit intofacebook:mainfrom
evanj wants to merge 1 commit intofacebook:mainfrom
Conversation
This is no longer true. This was changed in commit 1e9bf25 on 2022-07-21, which added calls to acquire mutex_ inside PreprocessWrite when needed. I noticed this while trying to better understand the RocksDB write code path. Fix 2 additional typos in the header comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is no longer true. This was changed in commit 1e9bf25 on 2022-07-21, which added calls to acquire mutex_ inside PreprocessWrite when needed. I noticed this while trying to better understand the RocksDB write code path.
Fix 2 additional typos in the header comments.