Rename CompactFiles() and CompactRange() in CompactionPickers#13831
Closed
jaykorean wants to merge 1 commit intofacebook:mainfrom
Closed
Rename CompactFiles() and CompactRange() in CompactionPickers#13831jaykorean wants to merge 1 commit intofacebook:mainfrom
jaykorean wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@jaykorean has imported this pull request. If you are a Meta employee, you can view this in D79660196. |
hx235
approved these changes
Aug 5, 2025
Contributor
hx235
left a comment
hx235
left a comment
There was a problem hiding this comment.
Thanks - they are now aligned better with CompactionPicker::PickCompaction() for auto compaction.
Contributor
|
@jaykorean merged this pull request in b6e804b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Summary
Quick follow-up from #13816:
CompactFiles()andCompactRange()in CompactionPickers do not run compaction as their names might suggest. What they actually do is create the Compaction object that will be passed toCompactionJobto run the compaction.Renaming these two functions to better represent their purposes.
Test Plan
No functional change. Existing CI should be sufficient.