Closed
Conversation
Contributor
Contributor
cbi42
reviewed
Aug 6, 2025
Contributor
cbi42
left a comment
cbi42
left a comment
There was a problem hiding this comment.
The change looks good to me. I think MultiScanArg may be a better name (similar to IngestExternalFileOptions vs IngestExternalFileArg). Options usually define things that affect how the specific operation is done and could be reused across operations. Though by the same argument, not sure if coalescing_threshold fits into MultiScanArg.
include/rocksdb/options.h
Outdated
| // Destructor | ||
| ~MultiScanOptions() {} | ||
|
|
||
| const std::vector<ScanOptions>& GetScanOptions() const { |
Contributor
Author
There was a problem hiding this comment.
Yea naming is hard. But yea changes it out here.
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To better support future options, and changes, we need to convert the std::vector to something more malleable.
This diff introduces the MultiScanOptions structure and pipes it through the various points in the code in the Prepare path.
Test Plan:
Ensure all associated tests pass