Disable Incompatible Tests with Remote Compaction#13843
Closed
jaykorean wants to merge 1 commit intofacebook:mainfrom
Closed
Disable Incompatible Tests with Remote Compaction#13843jaykorean wants to merge 1 commit intofacebook:mainfrom
jaykorean wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@jaykorean has imported this pull request. If you are a Meta employee, you can view this in D79735166. |
jaykorean
force-pushed
the
disable_incompatible_remote_compaction_tests
branch
from
6f22d2c to
f7bbf79
Compare
Contributor
|
@jaykorean has imported this pull request. If you are a Meta employee, you can view this in D79735166. |
jaykorean
force-pushed
the
disable_incompatible_remote_compaction_tests
branch
from
f7bbf79 to
8293753
Compare
Contributor
|
@jaykorean has imported this pull request. If you are a Meta employee, you can view this in D79735166. |
cbi42
approved these changes
Aug 6, 2025
Contributor
|
@jaykorean merged this pull request in 3dd6c6f. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
…tion in Stress Test (#13845) Summary: We temporarily disabled WAL when Remote Compaction is enabled in Stress Test (#13843). There are few others to incompatible features when WAL is disabled. Due to the sanitization order, WAL was disabled at the end of the sanitization and these incompatible features weren't set properly. Stress Test failed with an error like the following. e.g. `reopen` stress test is not compatible with `disable_wal` - `Error: Db cannot reopen safely with disable_wal set!` This PR changes the order of sanitization so that `disable_wal` is set earlier when `remote_compaction_worker_threads > 0` Pull Request resolved: #13845 Test Plan: ``` python3 -u tools/db_crashtest.py blackbox --remote_compaction_worker_threads=8 --interval=5 --duration=6000 --continuous_verification_interval=10 --disable_wal=1 --use_txn=1 --txn_write_policy=2 --enable_pipelined_write=0 --checkpoint_one_in=0 --use_timed_put_one_in=0 ``` Reviewed By: cbi42 Differential Revision: D79758670 Pulled By: jaykorean fbshipit-source-id: aa6f4a74cc86c23f442928c301187b06e8137f53
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
Summary: Previous attempts were not enough keep the stress test running with remote compaction enabled - #13845, #13843, #13835 We will disable the remote compaction in stress test and address this with a better strategy (using internal Meta infra) Pull Request resolved: #13848 Test Plan: CI Reviewed By: cbi42 Differential Revision: D79816733 Pulled By: jaykorean fbshipit-source-id: e93b037adf4f775202e06c3fd4aa8a3b4b85c274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To reduce the noise, disable the incompatible ones for now when
remote_compaction_worker_threads > 0. We will investigate each, fix as needed and re-enable them as follow up.Test Plan