Remove reservation mismatch assert in cache adapter destructor#13885
Remove reservation mismatch assert in cache adapter destructor#13885mszeszko-meta wants to merge 2 commits intofacebook:mainfrom
Conversation
|
@mszeszko-meta has imported this pull request. If you are a Meta employee, you can view this in D80355513. |
mszeszko-meta
force-pushed
the
remove_reservation_mismatch_assert_in_cache_adapter_destructor
branch
from
2925f7c to
c659c2a
Compare
|
@mszeszko-meta has imported this pull request. If you are a Meta employee, you can view this in D80355513. |
|
The fprintf to stderr is also going to cause crash test to fail. Is that the intention, or do you want to suppress it and allow the crash test to completion? |
Good catch! Yes, the intent was to log it in a non-intrusive way. Changed it to |
|
@mszeszko-meta has imported this pull request. If you are a Meta employee, you can view this in D80355513. |
|
@mszeszko-meta merged this pull request in 84f8144. |
3 participants
The assert occasionally throws off the stress test runs. We already have sufficient logging in place to collect the signal about secondary cache capacity exceeding primary cache reservation for further investigation.