Fix MultiScan Prepare() to support dictionary compression#13896
Closed
cbi42 wants to merge 2 commits intofacebook:mainfrom
Closed
Fix MultiScan Prepare() to support dictionary compression#13896cbi42 wants to merge 2 commits intofacebook:mainfrom
cbi42 wants to merge 2 commits intofacebook:mainfrom
Conversation
Contributor
Contributor
xingbowang
pushed a commit
to xingbowang/rocksdb
that referenced
this pull request
Sep 7, 2025
…3896) Summary: I saw failure when added some asserts near https://github.com/facebook/rocksdb/blob/b9957c991cae44959f96888369caf1b145398132/table/block_based/block_based_table_iterator.cc#L1201-L1205 in stress test. The decompression failed with error message like "Corruption: Failed zlib inflate: -3". This PR fixes the issue to use the right decompressor for dictionary compression. Pull Request resolved: facebook#13896 Test Plan: updated unit test that checks no I/O is done after Prepare(), this would fail before this change. Reviewed By: anand1976 Differential Revision: D80821500 Pulled By: cbi42 fbshipit-source-id: a4322c0da99a2d10e9787d0ec168668567c0c19a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: I saw failure when added some asserts near
rocksdb/table/block_based/block_based_table_iterator.cc
Lines 1201 to 1205 in b9957c9
Test plan: updated unit test that checks no I/O is done after Prepare(), this would fail before this change.