Ignore IOActivity check for ManagedSnapshot snapshot_guard(db_); for TestMultiScan#13898
Closed
hx235 wants to merge 1 commit intofacebook:mainfrom
Closed
Ignore IOActivity check for ManagedSnapshot snapshot_guard(db_); for TestMultiScan#13898hx235 wants to merge 1 commit intofacebook:mainfrom
hx235 wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
archang19
approved these changes
Aug 25, 2025
Contributor
Contributor
pcholakov
pushed a commit
to pcholakov/rocksdb
that referenced
this pull request
Aug 29, 2025
…TestMultiScan (facebook#13898) Summary: **Context/Summary:** RocksDB stress test verifies IOActivity is set correctly through reusing the pass-in Read/Write options through assertion. This is too strict for API that does not take or do not need to take Read/WriteOptions yet hence assertion failure. ``` stderr: db_stress: ... db_stress_tool/db_stress_env_wrapper.h:24: void rocksdb::(anonymous namespace)::CheckIOActivity(const IOOptions &): Assertion `io_activity == Env::IOActivity::kUnknown || io_activity == options.io_activity' failed. Received signal 6 (Aborted) ``` An example is ManagedSnapshot snapshot_guard(db_); in TestMultiScan(). This PR ignores such check. Pull Request resolved: facebook#13898 Test Plan: The same command repro-ed this assertion failure passes after this fix Reviewed By: archang19 Differential Revision: D80983214 Pulled By: hx235 fbshipit-source-id: d8b660f8c8771198bc7fa0e805c3e86d2584f03e
pcholakov
pushed a commit
to pcholakov/rocksdb
that referenced
this pull request
Aug 29, 2025
…TestMultiScan (facebook#13898) Summary: **Context/Summary:** RocksDB stress test verifies IOActivity is set correctly through reusing the pass-in Read/Write options through assertion. This is too strict for API that does not take or do not need to take Read/WriteOptions yet hence assertion failure. ``` stderr: db_stress: ... db_stress_tool/db_stress_env_wrapper.h:24: void rocksdb::(anonymous namespace)::CheckIOActivity(const IOOptions &): Assertion `io_activity == Env::IOActivity::kUnknown || io_activity == options.io_activity' failed. Received signal 6 (Aborted) ``` An example is ManagedSnapshot snapshot_guard(db_); in TestMultiScan(). This PR ignores such check. Pull Request resolved: facebook#13898 Test Plan: The same command repro-ed this assertion failure passes after this fix Reviewed By: archang19 Differential Revision: D80983214 Pulled By: hx235 fbshipit-source-id: d8b660f8c8771198bc7fa0e805c3e86d2584f03e
xingbowang
pushed a commit
to xingbowang/rocksdb
that referenced
this pull request
Sep 7, 2025
…TestMultiScan (facebook#13898) Summary: **Context/Summary:** RocksDB stress test verifies IOActivity is set correctly through reusing the pass-in Read/Write options through assertion. This is too strict for API that does not take or do not need to take Read/WriteOptions yet hence assertion failure. ``` stderr: db_stress: ... db_stress_tool/db_stress_env_wrapper.h:24: void rocksdb::(anonymous namespace)::CheckIOActivity(const IOOptions &): Assertion `io_activity == Env::IOActivity::kUnknown || io_activity == options.io_activity' failed. Received signal 6 (Aborted) ``` An example is ManagedSnapshot snapshot_guard(db_); in TestMultiScan(). This PR ignores such check. Pull Request resolved: facebook#13898 Test Plan: The same command repro-ed this assertion failure passes after this fix Reviewed By: archang19 Differential Revision: D80983214 Pulled By: hx235 fbshipit-source-id: d8b660f8c8771198bc7fa0e805c3e86d2584f03e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context/Summary:
RocksDB stress test verifies IOActivity is set correctly through reusing the pass-in Read/Write options through assertion. This is too strict for API that does not take or do not need to take Read/WriteOptions yet hence assertion failure.
An example is ManagedSnapshot snapshot_guard(db_); in TestMultiScan().
This PR ignores such check.
Test:
The same command repro-ed this assertion failure passes after this fix