OptionChangeMigration() to avoid full compaction for the same setting#1391
OptionChangeMigration() to avoid full compaction for the same setting#1391siying wants to merge 1 commit intofacebook:mainfrom
Conversation
siying
force-pushed
the
option_migration
branch
from
431d724 to
ab4e420
Compare
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Do we need to rebase this ? |
|
Let me rebase. |
|
@siying updated the pull request - view changes - changes since last import |
siying
force-pushed
the
option_migration
branch
from
54e4351 to
02b3e39
Compare
|
@siying updated the pull request - view changes - changes since last import |
|
@siying updated the pull request - view changes - changes since last import |
siying
force-pushed
the
option_migration
branch
from
1e3e828 to
9ed928e
Compare
|
@siying updated the pull request - view changes - changes since last import |
|
@siying updated the pull request - view changes - changes since last import |
|
Finally fixed the diff. |
There was a problem hiding this comment.
What will happen if level_compaction_dynamic_level_bytes was different ?
There was a problem hiding this comment.
good point. I'll fix it.
|
@IslamAbdelRahman has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@siying updated the pull request - view changes - changes since last import |
…ptions indicate the same LSM setting
siying
force-pushed
the
option_migration
branch
from
3cf65df to
a1a6419
Compare
|
@siying updated the pull request - view changes - changes since last import |
|
Hi @siying! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
4 participants
OptionChangeMigration() to avoid full compaction if the old and new options indicate the same LSM setting.