Skip to content

Turn on stats collection in crash test #13926

Closed
hx235 wants to merge 1 commit intofacebook:mainfrom
hx235:add_stat_to_crash_test
Closed

Turn on stats collection in crash test #13926
hx235 wants to merge 1 commit intofacebook:mainfrom
hx235:add_stat_to_crash_test

Conversation

@hx235
Copy link
Contributor

@hx235 hx235 commented Sep 8, 2025

Context/Summary: it's for formal testing to cover statistics in our stress test

Test plan: python3 tools/db_crashtest.py --simple blackbox --interval=10

@hx235 hx235 requested a review from anand1976 September 8, 2025 18:35
@meta-cla meta-cla bot added the CLA Signed label Sep 8, 2025
@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this in D81943762.

@hx235 hx235 requested a review from jaykorean September 8, 2025 18:39
@hx235 hx235 force-pushed the add_stat_to_crash_test branch from 6383cc4 to c8cdddc Compare September 8, 2025 18:41
Copy link
Contributor

@anand1976 anand1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for debugging purposes, or to test the stats code itself? Maybe mention in the description

@hx235
Copy link
Contributor Author

hx235 commented Sep 8, 2025

Is this for debugging purposes, or to test the stats code itself? Maybe mention in the description

Done thanks!

@hx235 hx235 force-pushed the add_stat_to_crash_test branch from c8cdddc to 1baf1dd Compare September 8, 2025 18:43
@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this in D81943762.

@facebook-github-bot
Copy link
Contributor

@hx235 merged this pull request in 6b02f13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants