Skip to content

Add Temperature::kIce#13927

Closed
pdillinger wants to merge 6 commits intofacebook:mainfrom
pdillinger:ice_temp
Closed

Add Temperature::kIce#13927
pdillinger wants to merge 6 commits intofacebook:mainfrom
pdillinger:ice_temp

Conversation

@pdillinger
Copy link
Contributor

Summary: ... and associated statistics, etc. Someone needs it, so here it is.

Test Plan: Updated / extended / added some unit tests

Summary: ... and associated statistics, etc. Someone needs it, so here
it is.

Test Plan: Updated / extended / added some unit tests
@pdillinger pdillinger requested a review from cbi42 September 9, 2025 00:10
@meta-cla meta-cla bot added the CLA Signed label Sep 9, 2025
@facebook-github-bot
Copy link
Contributor

@pdillinger has imported this pull request. If you are a Meta employee, you can view this in D81981469.

@facebook-github-bot
Copy link
Contributor

@pdillinger has imported this pull request. If you are a Meta employee, you can view this in D81981469.

Copy link
Contributor

@cbi42 cbi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}
return Histograms::HISTOGRAM_ENUM_MAX;
}
bool g_fail_on_hot = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks

@facebook-github-bot
Copy link
Contributor

@pdillinger has imported this pull request. If you are a Meta employee, you can view this in D81981469.

@facebook-github-bot
Copy link
Contributor

@pdillinger merged this pull request in 67af5bd.

pdillinger added a commit to pdillinger/rocksdb that referenced this pull request Sep 24, 2025
Summary: also requested by internal user, like kIce in facebook#13927

Test Plan: unit tests updated
facebook-github-bot pushed a commit that referenced this pull request Sep 25, 2025
Summary:
also requested by internal user, like kIce in #13927

Pull Request resolved: #14000

Test Plan: unit tests updated

Reviewed By: archang19

Differential Revision: D83200479

Pulled By: pdillinger

fbshipit-source-id: 31f2842d87bcad40227aeee9687ff5772393689c
xingbowang pushed a commit to xingbowang/rocksdb that referenced this pull request Sep 26, 2025
Summary:
also requested by internal user, like kIce in facebook#13927

Pull Request resolved: facebook#14000

Test Plan: unit tests updated

Reviewed By: archang19

Differential Revision: D83200479

Pulled By: pdillinger

fbshipit-source-id: 31f2842d87bcad40227aeee9687ff5772393689c
pdillinger added a commit that referenced this pull request Sep 30, 2025
Summary:
also requested by internal user, like kIce in #13927

Pull Request resolved: #14000

Test Plan: unit tests updated

Reviewed By: archang19

Differential Revision: D83200479

Pulled By: pdillinger

fbshipit-source-id: 31f2842d87bcad40227aeee9687ff5772393689c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants