Fix nullptr access in IsInjectedError() for stress test #13968
Closed
hx235 wants to merge 1 commit intofacebook:mainfrom
Closed
Fix nullptr access in IsInjectedError() for stress test #13968hx235 wants to merge 1 commit intofacebook:mainfrom
hx235 wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
hx235
commented
Sep 18, 2025
| specific_error_marker.empty() || | ||
| std::strstr(state, specific_error_marker.c_str()) != nullptr; | ||
|
|
||
| return is_injected_error && is_specific_error; |
Contributor
Author
There was a problem hiding this comment.
We should have done the two checks from the beginning for IsFailedToWriteToWALError() since the function is always under the context of injected error though it's harmless right now without it.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context/Summary:
Status::statecan be nullptr when created with no specific error message. std::strstr on nullptr caused some segfault in our stress test.Test plan:
Monitor stress test