(Re-)fix initialization order dep on kPageSize#13976
Closed
pdillinger wants to merge 1 commit intofacebook:mainfrom
Closed
(Re-)fix initialization order dep on kPageSize#13976pdillinger wants to merge 1 commit intofacebook:mainfrom
pdillinger wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Missed an occurrence of kPageSize in the last PR facebook#13973 Differential Revision: D82826713
Contributor
|
@pdillinger has exported this pull request. If you are a Meta employee, you can view the originating diff in D82826713. |
mszeszko-meta
approved these changes
Sep 19, 2025
Contributor
|
This pull request has been merged in 19c8d1b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Missed an occurrence of kPageSize in the last PR
#13973
Differential Revision: D82826713
Test plan:
This time I was able to reproduce the error with an internal workflow and
confirmed it's fixed