Avoid reseeking upon skipping too many keys in crash tests#14015
Closed
anand1976 wants to merge 3 commits intofacebook:mainfrom
Closed
Avoid reseeking upon skipping too many keys in crash tests#14015anand1976 wants to merge 3 commits intofacebook:mainfrom
anand1976 wants to merge 3 commits intofacebook:mainfrom
Conversation
xingbowang
approved these changes
Oct 2, 2025
Contributor
xingbowang
left a comment
xingbowang
left a comment
There was a problem hiding this comment.
Would be nice if we add some comments.
Contributor
|
MultiScan now supports "async_io". Maybe worth to turn it on now. But It might be better to run some local test first before turn it on. @cbi42 |
|
@anand1976 has imported this pull request. If you are a Meta employee, you can view this in D83761612. |
xingbowang
approved these changes
Oct 2, 2025
anand1976
force-pushed
the
mscan_stress
branch
from
e00d6ad to
3e85689
Compare
anand1976
force-pushed
the
mscan_stress
branch
from
3e85689 to
46603ff
Compare
Contributor
|
@anand1976 merged this pull request in bdf5a8f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implicit reseek in the middle of an iteration is not supported with MultiScan. Avoid this for now in crash tests by setting max_sequential_skip_in_iterations to an absurdly high value.