Move prepared_iter size assertion after cleanup#14144
Closed
jaykorean wants to merge 1 commit intofacebook:mainfrom
Closed
Move prepared_iter size assertion after cleanup#14144jaykorean wants to merge 1 commit intofacebook:mainfrom
jaykorean wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@jaykorean has imported this pull request. If you are a Meta employee, you can view this in D87656914. |
krhancoc
approved these changes
Nov 21, 2025
Contributor
krhancoc
left a comment
krhancoc
left a comment
There was a problem hiding this comment.
Will add a test case as a follow up to this that ensures we test when prepared iterators are not used.
|
@jaykorean merged this pull request in 2f583ae. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixing crash test failure caused by
prepared_iters_.size() == 0Test Plan