Add a cleanup target to crash_test.mk#14286
Closed
anand1976 wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
|
@anand1976 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91912877. |
jaykorean
approved these changes
Feb 2, 2026
Contributor
jaykorean
left a comment
jaykorean
left a comment
There was a problem hiding this comment.
Thanks! QQ. I assume it's no-op if the tmpdir is already gone?
pdillinger
approved these changes
Feb 2, 2026
crash_test.mk
Outdated
| whitebox_crash_test_with_txn whitebox_crash_test_with_ts \ | ||
| whitebox_crash_test_with_optimistic_txn \ | ||
| whitebox_crash_test_with_tiered_storage \ | ||
| db_cleanup \ |
Contributor
There was a problem hiding this comment.
I would prefer crash_test_db_cleanup
Summary: Add the db_c leanup target which can be used by CI test scripts to delete the db on failure. The db_crashtest.py doesn't automatically delete on error. Reviewed By: jaykorean Differential Revision: D91912877
anand1976
force-pushed
the
export-D91912877
branch
from
3f05fcf to
19c8d19
Compare
Contributor
Author
@jaykorean @pdillinger I realized that even with my original change, the parent of the db directory and any other dirs under it (eg dbstress_secondaries) would be leaked. I modified the PR to delete from the parent down recursively. |
|
This pull request has been merged in 82ff067. |
joshkang97
pushed a commit
to joshkang97/rocksdb
that referenced
this pull request
Feb 5, 2026
Summary: Pull Request resolved: facebook#14286 Add the db_c leanup target which can be used by CI test scripts to delete the db on failure. The db_crashtest.py doesn't automatically delete on error. Reviewed By: jaykorean Differential Revision: D91912877 fbshipit-source-id: d36ec0896fba64faaafe055d8673e437e85d0c3a
anand1976
added a commit
that referenced
this pull request
Feb 6, 2026
Summary: Pull Request resolved: #14286 Add the db_c leanup target which can be used by CI test scripts to delete the db on failure. The db_crashtest.py doesn't automatically delete on error. Reviewed By: jaykorean Differential Revision: D91912877 fbshipit-source-id: d36ec0896fba64faaafe055d8673e437e85d0c3a
archang19
pushed a commit
that referenced
this pull request
Feb 6, 2026
Summary: Pull Request resolved: #14286 Add the db_c leanup target which can be used by CI test scripts to delete the db on failure. The db_crashtest.py doesn't automatically delete on error. Reviewed By: jaykorean Differential Revision: D91912877 fbshipit-source-id: d36ec0896fba64faaafe055d8673e437e85d0c3a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add the db_c leanup target which can be used by CI test scripts to delete the db on failure. The db_crashtest.py doesn't automatically delete on error.
Differential Revision: D91912877