Remove obsolete compression code and some .h->.cc movement#14325
Closed
pdillinger wants to merge 1 commit intofacebook:mainfrom
Closed
Remove obsolete compression code and some .h->.cc movement#14325pdillinger wants to merge 1 commit intofacebook:mainfrom
pdillinger wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: In follow-up to facebook#14315 Remove obsolete code replaced by new Compressor/Decompressor interface: * CompressionInfo and UncompressionInfo classes * UncompressionDict class * Individual compression/decompression functions (Snappy_*, Zlib_*, BZip2_*, LZ4_*, LZ4HC_*, XPRESS_*, ZSTD_Compress, ZSTD_Uncompress) * OLD_CompressData and OLD_UncompressData * compression::PutDecompressedSizeInfo and GetDecompressedSizeInfo The only small refactoring in this change that is not pure code removal or movement is in blob_file_builder_test.cc. Move some function implementations etc. from compression.h to compression.cc: * CompressionTypeToString, CompressionTypeFromString, CompressionOptionsToString * ZSTD_TrainDictionary (both overloads), ZSTD_FinalizeDictionary * DecompressorDict::Populate * Most compression library includes Also cleaned up other includes of compression.h, which caused some other files to need new includes. Test Plan: existing tests
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this in D93120580. |
hx235
reviewed
Feb 13, 2026
| #include "rocksdb/advanced_options.h" | ||
| #include "table/table_reader.h" | ||
| #include "table/unique_id_impl.h" | ||
| #include "test_util/sync_point.h" |
Contributor
There was a problem hiding this comment.
new behavior of make format???
Contributor
There was a problem hiding this comment.
similar for env/env.cc and options/cf_options.cc
Contributor
Author
There was a problem hiding this comment.
No, just fixing fallout of tidying up includes of compression.h. "Also cleaned up other includes of compression.h, which caused some other files to need new includes."
hx235
approved these changes
Feb 13, 2026
|
@pdillinger merged this pull request in 672389f. |
doxtop
pushed a commit
to flyingw/rocksdb
that referenced
this pull request
Apr 7, 2026
…14325) Summary: In follow-up to facebook#14315 Remove obsolete code replaced by new Compressor/Decompressor interface: * OLD_CompressData and OLD_UncompressData * Individual compression/decompression functions (Snappy_*, Zlib_*, BZip2_*, LZ4_*, LZ4HC_*, XPRESS_*, ZSTD_Compress, ZSTD_Uncompress) * CompressionInfo and UncompressionInfo classes * UncompressionDict class * compression::PutDecompressedSizeInfo and GetDecompressedSizeInfo The only small refactoring in this change that is not pure code removal or movement is in blob_file_builder_test.cc. Move some function implementations etc. from compression.h to compression.cc: * CompressionTypeToString, CompressionTypeFromString, CompressionOptionsToString * ZSTD_TrainDictionary (both overloads), ZSTD_FinalizeDictionary * DecompressorDict::Populate * Most compression library includes Also cleaned up other includes of compression.h, which caused some other files to need new includes. Pull Request resolved: facebook#14325 Test Plan: existing tests Reviewed By: hx235 Differential Revision: D93120580 Pulled By: pdillinger fbshipit-source-id: ab5c50db7379c0387a8c0e379642c9ea2799eae5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: In follow-up to #14315
Remove obsolete code replaced by new Compressor/Decompressor interface:
The only small refactoring in this change that is not pure code removal or movement is in blob_file_builder_test.cc.
Move some function implementations etc. from compression.h to compression.cc:
Also cleaned up other includes of compression.h, which caused some other files to need new includes.
Test Plan: existing tests