Update buckifier to use folly/coro instead of folly/experimental/coro (#14685)

[pdillinger]

Summary:

D102823090 migrated the generated RocksDB BUCK file from
//folly/experimental/coro:* to //folly/coro:*, but did not update
the buckifier script that generates it. This leaves the BUCK file and
buckifier out of sync — the next buckifier run would revert the BUCK
change.

Update buckify_rocksdb.py to match, so the generated BUCK file stays
consistent with the folly coro migration.

Reviewed By: nmk70

Differential Revision: D103096688

[meta-codesync]

@pdillinger has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103096688.

[github-actions]

✅ clang-tidy: No findings on changed lines

Completed in 0.0s.

[github-actions]

✅ Claude Code Review

Auto-triggered after CI passed — reviewing commit c8e8a7a

---

Code Review: Update buckifier to use folly/coro instead of folly/experimental/coro

PR: Update buckifier to use folly/coro instead of folly/experimental/coro
Author: pdillinger
Scope: 1 file changed, 4 insertions, 4 deletions

Summary

This PR fixes a consistency gap between the generated BUCK file and the buckifier script that generates it. A prior change (D102823090) migrated the BUCK file from //folly/experimental/coro:* to //folly/coro:*, but did not update buckifier/buckify_rocksdb.py. Without this fix, the next buckifier run would revert the BUCK file back to the old paths.

Verification

• BUCK file (generated output) already uses //folly/coro:* at lines 381-384
• buckify_rocksdb.py (generator) still uses //folly/experimental/coro:* at lines 149-152
• All C++ source files already use the new folly/coro/ include paths (confirmed in util/coro_utils.h, util/async_file_reader.h, table/table_reader.h, db/version_set.h, db/version_set.cc)
• No remaining references to folly/experimental/coro exist anywhere in the codebase except the buckifier script being fixed

Findings

No issues found. This is a correct, minimal, and low-risk change.

Category	Assessment
Correctness	The four string replacements exactly match the paths already present in the generated BUCK file.
Completeness	All four folly coro dependencies are updated. No references are missed.
Consistency	After this change, the buckifier, the BUCK file, and all C++ source includes are aligned on folly/coro.
Risk	Near-zero. Only affects Meta-internal BUCK build file generation. No C++, tests, Makefile, or CMake touched.
Testing	No additional tests needed. Validate by running buckifier and confirming BUCK output is unchanged.

Recommendation

Approve. The change is correct, complete, and necessary to prevent the next buckifier run from reverting the folly coro migration.

---

ℹ️ About this response

Generated by Claude Code.
Review methodology: claude_md/code_review.md

Limitations:

• Claude may miss context from files not in the diff
• Large PRs may be truncated
• Always apply human judgment to AI suggestions

Commands:

• /claude-review [context] — Request a code review
• /claude-query <question> — Ask about the PR or codebase

[meta-codesync]

This pull request has been merged in fa8f4f1.