Skip to content

Update folly hash for 11.6 release#14912

Open
anand1976 wants to merge 2 commits into
mainfrom
update-folly-11.6
Open

Update folly hash for 11.6 release#14912
anand1976 wants to merge 2 commits into
mainfrom
update-folly-11.6

Conversation

@anand1976

Copy link
Copy Markdown
Contributor

Summary

  • Update folly.mk FOLLY_COMMIT_HASH to 2a68075b77d9

This is folly's main at release-cut time. Review and merge to take the bump, or close to skip folly for this release.

Part of 11.6 release workflow.

@meta-cla meta-cla Bot added the CLA Signed label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

✅ clang-tidy: No findings on changed lines

Completed in 0.0s.

@meta-codesync

meta-codesync Bot commented Jul 2, 2026

Copy link
Copy Markdown

@pdillinger has imported this pull request. If you are a Meta employee, you can view this in D110524765.

@meta-codesync

meta-codesync Bot commented Jul 2, 2026

Copy link
Copy Markdown

@pdillinger has imported this pull request. If you are a Meta employee, you can view this in D110524765.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

🟡 Codex Code Review

Auto-triggered after CI reached the early-review threshold — reviewing commit b6ca6d8


Codex review failed before producing findings.

WARNING: proceeding, even though we could not create PATH aliases: Refusing to create helper binaries under temporary dir "/tmp" (codex_home: AbsolutePathBuf("/tmp/codex-home"))
error: the argument '--base <BRANCH>' cannot be used with '[PROMPT]'

Usage: codex exec review --commit <SHA> --base <BRANCH> --title <TITLE> --model <MODEL> --config <key=value> --dangerously-bypass-approvals-and-sandbox --output-last-message <FILE> [PROMPT]

For more information, try '--help'.

ℹ️ About this response

Generated by Codex CLI.
Review methodology: claude_md/code_review.md

Limitations:

  • Codex may miss context from files not in the diff
  • Large PRs may be truncated
  • Always apply human judgment to AI suggestions

Commands:

  • /codex-review [context] — Request a code review
  • /codex-query <question> — Ask about the PR or codebase

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

✅ Claude Code Review

Auto-triggered after CI reached the early-review threshold — reviewing commit b6ca6d8


Summary

This PR updates the pinned folly commit hash in folly.mk from 548b16da... to 2a68075b77d9..., bumping to folly's main at the 11.6 release-cut time. This is a routine dependency version bump with no logic, API, or behavioral changes to RocksDB code.

No high-severity findings.

Full review (click to expand)

Findings

🔴 HIGH

None.

🟡 MEDIUM

None.

🟢 LOW / NIT

L1. New folly commit not independently verified — folly.mk:101
  • Issue: The new commit hash 2a68075b77d9... should be verified to exist on facebook/folly main and to build successfully with RocksDB's checkout_folly + build_folly targets. The checkout_folly target applies source patches (missing <cstring> include in Exception.h, const mismatch in Subprocess.cpp) that may or may not still be needed or may need updating for the new folly version.
  • Suggested fix: Confirm CI passes with the folly build job (USE_FOLLY=1). If patches in checkout_folly are no longer needed or need updating, address in a follow-up.

Cross-Component Analysis

This change has zero cross-component impact within RocksDB itself. The FOLLY_COMMIT_HASH variable is only used by the checkout_folly Make target (folly.mk:138) to pin git reset --hard to a specific folly commit. No RocksDB source code, headers, build flags, or runtime behavior are modified.

Context Affected? Notes
Non-folly builds No Hash is unused unless make checkout_folly is invoked
USE_FOLLY=1 builds Yes Will fetch and build the new folly version
USE_FOLLY_LITE=1 builds Indirectly checkout_folly fetches boost/fmt sources used by LITE mode
All other build modes No No impact

Positive Observations

  • The change is minimal and well-scoped — exactly one variable updated.
  • The PR description clearly states the purpose (11.6 release workflow) and gives reviewers the option to close if folly bump should be skipped.
  • Pinning to a specific commit hash (rather than a branch) is good practice for reproducible builds.

ℹ️ About this response

Generated by Claude Code.
Review methodology: claude_md/code_review.md

Limitations:

  • Claude may miss context from files not in the diff
  • Large PRs may be truncated
  • Always apply human judgment to AI suggestions

Commands:

  • /claude-review [context] — Request a code review
  • /claude-query <question> — Ask about the PR or codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants