Update folly hash for 11.6 release#14912
Conversation
✅ clang-tidy: No findings on changed linesCompleted in 0.0s. |
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this in D110524765. |
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this in D110524765. |
🟡 Codex Code ReviewAuto-triggered after CI reached the early-review threshold — reviewing commit b6ca6d8 ❌ Codex review failed before producing findings. ℹ️ About this responseGenerated by Codex CLI. Limitations:
Commands:
|
✅ Claude Code ReviewAuto-triggered after CI reached the early-review threshold — reviewing commit b6ca6d8 SummaryThis PR updates the pinned folly commit hash in No high-severity findings. Full review (click to expand)Findings🔴 HIGHNone. 🟡 MEDIUMNone. 🟢 LOW / NITL1. New folly commit not independently verified —
|
| Context | Affected? | Notes |
|---|---|---|
| Non-folly builds | No | Hash is unused unless make checkout_folly is invoked |
| USE_FOLLY=1 builds | Yes | Will fetch and build the new folly version |
| USE_FOLLY_LITE=1 builds | Indirectly | checkout_folly fetches boost/fmt sources used by LITE mode |
| All other build modes | No | No impact |
Positive Observations
- The change is minimal and well-scoped — exactly one variable updated.
- The PR description clearly states the purpose (11.6 release workflow) and gives reviewers the option to close if folly bump should be skipped.
- Pinning to a specific commit hash (rather than a branch) is good practice for reproducible builds.
ℹ️ About this response
Generated by Claude Code.
Review methodology: claude_md/code_review.md
Limitations:
- Claude may miss context from files not in the diff
- Large PRs may be truncated
- Always apply human judgment to AI suggestions
Commands:
/claude-review [context]— Request a code review/claude-query <question>— Ask about the PR or codebase
Summary
folly.mkFOLLY_COMMIT_HASH to 2a68075b77d9This is folly's
mainat release-cut time. Review and merge to take the bump, or close to skip folly for this release.Part of 11.6 release workflow.