[RocksJava] Slice / DirectSlice improvements#437
Merged
Conversation
fyrz
commented
Dec 10, 2014
fyrz
commented
Contributor
- Assertion if Buffer was initialized with Non-Direct memory
- Tests + coverage for DirectSlice
- Slice SigSegv fixes when initializing from String and Byte-Arrays
- Slice Tests
fyrz
force-pushed
the
RocksJava-SliceTests-Fixes
branch
3 times, most recently
from
7ca9ce7 to
991b0fd
Compare
Contributor
Author
|
Differential: https://reviews.facebook.net/D30081 |
fyrz
force-pushed
the
RocksJava-SliceTests-Fixes
branch
2 times, most recently
from
56edbb8 to
2b9c943
Compare
Summary: - AssertionError when initialized with Non-Direct Buffer - Tests + coverage for DirectSlice - Slice sigsegv fixes when initializing from String and byte arrays - Slice Tests Test Plan: Run tests without source modifications. Reviewers: yhchiang, adamretter, ankgup87 Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D30081
fyrz
force-pushed
the
RocksJava-SliceTests-Fixes
branch
from
2b9c943 to
1fed128
Compare
yhchiang
added a commit
that referenced
this pull request
Dec 18, 2014
[RocksJava] Slice / DirectSlice improvements
gz
pushed a commit
to gz/rocksdb
that referenced
this pull request
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.