Add new stats for async and non async reads in FilePrefetchBuffer #9751
Conversation
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
akankshamahajan15
changed the title
akankshamahajan15
force-pushed
the
stats
branch
from
10ad96f to
b9b64e2
Compare
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
akankshamahajan15
force-pushed
the
stats
branch
from
b9b64e2 to
1147c8c
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
anand1976
left a comment
anand1976
left a comment
There was a problem hiding this comment.
LGTM. Needs rebase and resolution of merge conflicts.
Summary: Add stats "NUM_SYNC_PREFETCH" and "NUM_ASYNC_PREFETCH" that tells number of synchronous and asynchronous calls made in FilePrefetchBuffer. Test Plan: Update existing unit tests.
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
akankshamahajan15
changed the title
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
3 participants
Summary: Add stats "NUM_SYNC_PREFETCH" and "NUM_ASYNC_PREFETCH" that tells
number of synchronous and asynchronous calls made in FilePrefetchBuffer.
Test Plan: Update existing unit tests.