[eslint-plugin] Add flexFlow shorthand expansion to stylex-valid-shorthands#1589
Open
abhakat wants to merge 3 commits intoplace-shorthand-autofixfrom
Open
[eslint-plugin] Add flexFlow shorthand expansion to stylex-valid-shorthands#1589abhakat wants to merge 3 commits intoplace-shorthand-autofixfrom
abhakat wants to merge 3 commits intoplace-shorthand-autofixfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
2 tasks
workflow: benchmarks/perfComparison of performance test results, measured in operations per second. Larger is better.
|
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand
flexFlowshorthand intoflexDirection+flexWraplonghands. Both tokens arevalidated against keyword sets before applying the fix, preventing incorrect expansions
for invalid values.
Stack: 5/7 — depends on #1588
What changed / motivation ?
flexFlow: 'row wrap'→flexDirection: 'row'+flexWrap: 'wrap'flexFlow: 'wrap column'→flexDirection: 'column'+flexWrap: 'wrap'(order-independent)flexFlow: 'row banana'→ error with no autofix (invalid wrap token)Linked PR/Issues
Follow-up to #1537
Additional Context
Added tests covering: single-value passthrough, direction+wrap expansion, reversed token order,
invalid tokens (CANNOT_FIX), column-reverse/nowrap.
Pre-flight checklist
Contribution Guidelines