[eslint-plugin] Add columnRule/columns/listStyle/caret shorthand expansion to stylex-valid-shorthands#1590
Open
abhakat wants to merge 3 commits intoflexflow-shorthand-autofixfrom
Open
Conversation
added 2 commits
April 3, 2026 13:45
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
2 tasks
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
workflow: benchmarks/perfComparison of performance test results, measured in operations per second. Larger is better.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand
columnRule,columns,listStyle, andcaretshorthands into their longhandequivalents.
columnRulereuses the existing border-like expansion.listStylehandles theCSS
nonekeyword correctly (applies to both type and image when unambiguous).columnsusesinteger/length disambiguation to determine which value is width vs count.
Stack: 6/7 — depends on #1589
What changed / motivation ?
columnRule: '1px solid red'→columnRuleWidth+columnRuleStyle+columnRuleColorcolumns: '200px 3'→columnWidth: '200px'+columnCount: '3'listStyle: 'disc inside url(bullet.png)'→listStyleType+listStylePosition+listStyleImagecaret: 'red bar'→caretColor: 'red'+caretShape: 'bar'Linked PR/Issues
Follow-up to #1553, #1552
Additional Context
Added tests covering: single-value passthrough, multi-value expansion,
nonehandling inlistStyle, auto/integer disambiguation in columns, reversed token order in caret, url() images.
Pre-flight checklist
Contribution Guidelines