Extend ntsketest to the full KE->NTPv4 round-trip#568
Closed
sofiascalzo wants to merge 1 commit into
Closed
Conversation
Summary: Extended smoke to prove the whole authenticated exchange works end to end. This extends it to run the NTPv4 phase after KE build a signed request, send it, and verify the response reusing the shared client helpers so the tool stays a thin driver. A server-side test also drives the real request path with those public helpers. Reviewed By: vvfedorenko Differential Revision: D113441692
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@sofiascalzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113441692. |
Contributor
|
This pull request has been merged in b2dde4c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Extended smoke to prove the whole authenticated exchange works end to end. This extends it to run the NTPv4 phase after KE
build a signed request, send it, and verify the response
reusing the shared client helpers so the tool stays a thin driver. A server-side test also drives the real request path with those public helpers.
Reviewed By: vvfedorenko
Differential Revision: D113441692